Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create preset for kitchen garden #1135

Merged
merged 1 commit into from Feb 24, 2024
Merged

Create preset for kitchen garden #1135

merged 1 commit into from Feb 24, 2024

Conversation

imagoiq
Copy link
Contributor

@imagoiq imagoiq commented Feb 23, 2024

There are presets for "residential" and "community" garden:type (#714). This one adds a preset for kitchen garden. Like the others, it's a de facto tag with some usages (> 1200), see the original proposal.

Copy link

🍱 You can preview the tagging presets of this pull request here.

Copy link
Member

@tyrasd tyrasd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks ok. I'd only like to see this tag value been described on the wiki; at least as an entry on the table for the garden:type tag key. Once that's done, this preset can be added here as well.

@tyrasd tyrasd added the waitfor-documentation documentation about this tag is missing in the OSM wiki label Feb 24, 2024
@imagoiq
Copy link
Contributor Author

imagoiq commented Feb 24, 2024

Thanks, you're right, I've added the type to the table.

@tyrasd tyrasd removed the waitfor-documentation documentation about this tag is missing in the OSM wiki label Feb 24, 2024
@tyrasd tyrasd merged commit c7d19b3 into openstreetmap:main Feb 24, 2024
5 checks passed
@imagoiq
Copy link
Contributor Author

imagoiq commented Feb 24, 2024

@tyrasd I double checked the preview and there are two fields which doesn't make sense in this case ("Allowed access" and "Fee"). Is there a way to remove them by default?

image

@simonpoole
Copy link

simonpoole commented Mar 25, 2024

May I point out that kitchen was/is a (semi-documented) value for garden:style not garden:type, the numbers would further indicate that the 1'300 occurrences are simply a mis-tagging and should be corrected to garden:style This PR would seem to be creating unnecessary divergent tagging.

@tyrasd
Copy link
Member

tyrasd commented Mar 26, 2024

Thanks Simon, I completely missed that. I do agree that the use of the more common and previously documented tag is better.

//edit: fixed in 9505676

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason why this preset has "matchScore": 1.1? This causes the preset to be the first suggestion when you search for Garde…, while all the other garden types are at the bottom of the list

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants