Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add presets for ski jump tagging #1176

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add presets for ski jump tagging #1176

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
70d6c49
Add presets for ski jump tagging
olafkryus Mar 23, 2024
065a3ec
Update data/presets/man_made/ski_jump.json
olafkryus Mar 31, 2024
e2f42db
Update data/fields/sport.json
olafkryus Mar 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion data/fields/piste/type.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,8 @@
"ice_skate": "Ice Skate",
"snow_park": "Snow Park",
"playground": "Playground",
"connection": "Connection"
"connection": "Connection",
"ski_jump": "Ski Jump"
}
},
"autoSuggestions": false,
Expand Down
1 change: 1 addition & 0 deletions data/fields/sport.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@
"shooting": "Shooting",
"skateboard": "Skateboard",
"skiing": "Skiing",
"ski_jumping": "Ski Jumping",
"soccer": "Soccer",
"softball": "Softball",
"speedway": "Motorcycle Speedway",
Expand Down
28 changes: 28 additions & 0 deletions data/presets/man_made/ski_jump.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
{
"icon": "temaki-ski_jumping",
"fields": [
"name",
"operator"
],
"moreFields": [
"building"
],
"geometry": [
"point",
"area"
],
"terms": [
"jump",
"ski jump",
"in-run",
"inrun",
"ski jump structure",
"ski jumping hill structure",
"ski jump in-run",
"ski jumping hill in-run tower"
],
"tags": {
"man_made": "ski_jump"
},
tyrasd marked this conversation as resolved.
Show resolved Hide resolved
"name": "Ski Jumping Hill Structure / In-Run Tower"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe this could be slightly shortened to the following?

Suggested change
"name": "Ski Jumping Hill Structure / In-Run Tower"
"name": "Ski Jumping In-Run/Tower"

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While in most of the cases it is true that man-made part is equal to the in-run tower.
It is also not uncommon for the man-made structure to include more than the in-run itself if the terrain is too flat (e.g.: Holmenkollen).
There are also ski jumps on slopes that happen to be just right (e.g. as seen here) and whether they really qualify as "man-made" (or "tower") is debatable.
If shortening of this (quite long I agree) name is desired, I would rather opt for Ski Jumping Hill Structure.

}
23 changes: 23 additions & 0 deletions data/presets/piste/ski_jump.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
{
"icon": "temaki-ski_jumping",
"fields": [
"name",
"piste/type",
"ref",
"oneway_yes",
"lit"
],
"geometry": [
"line",
"area"
],
"tags": {
"piste:type": "ski_jump"
},
"terms": [
"jump",
"ski jump",
"ski jumping hill"
],
"name": "Ski Jumping Piste"
}
21 changes: 21 additions & 0 deletions data/presets/piste/take_off.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
{
"icon": "temaki-ski_jumping",
"fields": [
"height"
],
"geometry": [
"vertex"
],
"tags": {
"piste:takeoff": "yes"
},
"terms": [
"jump",
"ski jump",
"take-off",
"takeoff",
"ski jump take-off",
"ski jumping hill take-off"
],
"name": "Ski Jumping Hill Take-Off Point"
}