Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bicycle_repair_station.json #1231

Merged
merged 1 commit into from
Jun 5, 2024
Merged

Conversation

pietervdvn
Copy link
Contributor

Add 'compressed air' as some people search for this term when they want to add a bicycle pump

Add 'compressed air' as some people search for this term when they want to add a bicycle pump
Copy link

🍱 You can preview the tagging presets of this pull request here.

@tordans tordans merged commit 87b710d into openstreetmap:main Jun 5, 2024
5 checks passed
@tordans
Copy link
Collaborator

tordans commented Jun 5, 2024

Thanks for the addition.


This is what it looks like in the search:

image

A few notes from my research

  • I wonder if we need better keywords for "bicycle air pump" which is what the translations gives me for "Fahrradluftpumpe". But our presets don't handle those terms well: The compressed air shows up very low and the repair station not at all.
  • https://wiki.openstreetmap.org/wiki/Tag:amenity%3Dcompressed_air gives a good explanation on why this keyword is a good fit for this tag

    While amenity=compressed_air was historically used for both car and bicycle pumps, but usage for bicycle pumps has shifted to amenity=bicycle_repair_station with service:bicycle:pump=yes - the latter having 9400 instances as of may 2024 - whereas amenity=compressed_air with bicycle=* has only about 100 entries.
    Compressed air for bicycles is often offered as part of amenity=bicycle_repair_station, which has more services than just air. Since amenity=compressed_air is usually oriented towards cars, some people prefer to map cycle pumps as a bicycle repair station with just a pump and no other services.

@tordans tordans added the new-label changes the name, aliases or terms of a preset label Jun 6, 2024
@pietervdvn
Copy link
Contributor Author

This is what it looks like in the search:

Looks perfect; although a preset for "bicycle pump" (with amenity=bicycle_repair_station; service:bicycle:pump=yes might be useful as well to counter your first note)

https://wiki.openstreetmap.org/wiki/Tag:amenity%3Dcompressed_air gives a good explanation on why this keyword is a good fit for this tag

It is me who added this paragraph about historic usage...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-label changes the name, aliases or terms of a preset
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants