add reservoir_type=tailings #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add several combinaison with the depreciated tag reservoir_type=tailings
tyrasd
changed the title
tyrasd
previously requested changes
Dec 14, 2021
There was a problem hiding this comment.
For this to work well, we also need a preset for the new man_made=tailings_pond tag. otherwise users would be presented with the rather generic preset for a "man made feature" after upgrading the tags. @Marc-marc-marc can you please add that here?
I guess that it would be also OK with separate PR? If someone else would want to do this or @Marc-marc-marc is stuck with git/github interface? |
|
👍 sure, for me it would be also fine if someone else took over (if it's ok with @Marc-marc-marc of course). Just base your PR/branch of from this one. |
tyrasd
added
deprecating
new-preset
and removed
enhancement
tyrasd
force-pushed
the
main
branch
2 times, most recently
from
9d3204d
to
49f529e
Compare
tyrasd
added a commit
that referenced
this pull request
Oct 17, 2022
tyrasd
dismissed
their stale review
I've added the preset for this tag in 562c26f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add several combinaison with the depreciated tag reservoir_type=tailings
closes #142