add fields for level crossing #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good |
This was referenced Jul 11, 2021
Closed
Closed
Closed
mbrzakovic
requested changes
Nov 12, 2021
There was a problem hiding this comment.
Nicely done, thanks for explanation and this feature.
I just wanted to double check and hear some opinions if these fields are indeed valid for tram crossings (tram_crossing, tram_level_crossing).
I observed partial information on this combination in wiki and very low usage in tag info.
Perhaps we could remove these for now and return them if usage spikes in osm,
k-yle
force-pushed
the
level_crossing
branch
from
9d37a66
to
7f62142
Compare
|
thanks @mbrzakovic, I've removed these fields from |
mbrzakovic
approved these changes
Nov 15, 2021
1ec5
reviewed
Dec 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Every year, hundreds of people die at railway level crossings. Mapping the safety features of railway crossings in OSM would be very valuable. There are already tags to describe the safety features of level crossings, iD just doesn't have a preset for them (
crossing:barrier,crossing:bell,crossing:light). These descriptive tags have less usage (36k-88k) compared to the main tagrailway=level_crossing(908k).This PR adds three new fields:
crossing:barrier,crossing:bell,crossing:lightto the four types of level crossings:railway=level_crossing,railway=crossing,railway=tram_level_crossing,railway=tram_crossing