Translatable strings for crops #257
Conversation
| "grass": "Grass", | ||
| "hop": "Hops", | ||
| "lavender": "Lavender", | ||
| "maize": "Corn", |
There was a problem hiding this comment.
The wiki argues that maize is preferable to corn and marks corn as deprecated due to ambiguity. However, corn is orders of magnitude more common in the database, so it’ll show up toward the top of the list, untranslated, while this translated string appears much lower.
The source strings are in American English by default. The Australian English and New Zealand English localizations should keep this string unchanged. The British English and probably Indian English localizations will need to translate it to “Maize”.
There was a problem hiding this comment.
The deprecation of crop=corn is being challenged on the tagging list. Regardless, this PR is merely also labeling crop=maize as “Corn” for the American English locale, which should be uncontroversial. (I grew up in a corn-producing area in the U.S. No one there knows what maize is, but everyone knows what a corn maze is.)
There was a problem hiding this comment.
merely also labeling crop=maize as “Corn”
One downside of this is that the list would contain two entries labeled as corn (once for the corn tag value itself and once for the translation of the maize value), with only slight differences in style and spelling… not ideal
PS: A similar issue exist for vegetable which is labeled as Vegetables, but vegetables is also a relatively often used value for the tag.
There was a problem hiding this comment.
If deprecation would be upheld maybe having Corn (old tagging) / Corn (deprecated) would be survivable?
Or maybe having some list of excluded values, blocked from appearing?
Maybe deprecation rule would be OK?
There was a problem hiding this comment.
omitted values that the documentation seems to discourage
I think we should document which these were, to avoid that at some time in the future we wonder why a certain value was not included in this list.
argues that
maizeis preferable tocorn
See inline comment below.
used more than 100 times.
🤔 I'm not 100% sure if this is the right approach. One issue, for example, is that the list could become outdated relatively quickly (we would kind of need a way to monitor changes in usage of the tag). Wouldn't it make more sense to just use the list as on the OSM wiki (just excluding "discouraged" entries)? This would probably allow for easier syncing of future changes.
| "grass": "Grass", | ||
| "hop": "Hops", | ||
| "lavender": "Lavender", | ||
| "maize": "Corn", |
There was a problem hiding this comment.
merely also labeling crop=maize as “Corn”
One downside of this is that the list would contain two entries labeled as corn (once for the corn tag value itself and once for the translation of the maize value), with only slight differences in style and spelling… not ideal
PS: A similar issue exist for vegetable which is labeled as Vegetables, but vegetables is also a relatively often used value for the tag.
It was an arbitrary cutoff, to be sure. Normally I would prefer to just go off of the list on the wiki, but this particular wiki page is a mess. Apart from the values explicitly marked as “avoid”, the page also remarks that some values are “unspecific” or says to see some other tag – does that mean the documented tag is problematic? What about the crops that have multiple documented spellings? Despite the mess, it would be great if we could at least make some of the more certain values localizable. Maybe we could limit the PR to just the values used by StreetComplete for now? |
tyrasd
force-pushed
the
main
branch
2 times, most recently
from
9d3204d
to
49f529e
Compare
|
Maybe maize / corn mess can be skipped for now and moved to a separate PR? |
tyrasd
added
new-label
Added translatable strings for the Crops field based on the most common documented values of the
cropkey used more than 100 times. I’ve omitted values that the documentation seems to discourage and picked the more common value wherever the documentation offers both as equally valid options. This list is not nearly as comprehensive as the crops-parser list, but that’s OK because these strings are only used to pretty-print the list of most common values in the database.