fix the office preset disappearing for custom values #661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dimitar5555
added a commit
to Dimitar5555/id-tagging-schema
that referenced
this pull request
Feb 17, 2023
* Deploying to main from @ openstreetmap/id-tagging-schema@d7dc30d 🚀 * mention wiki and similar as "related projects" in readme closes openstreetmap#629 * add related projects see openstreetmap#629 * add "Bridge" alias for man_made=bridge, closes openstreetmap#632 also reverts lowered match score from openstreetmap/iD@67f7995 * Add Tree Stump Preset and update ATM icon (openstreetmap#630) * Deploying to main from @ openstreetmap/id-tagging-schema@f8b134f 🚀 * improve naming consistency * add preset for `footway=traffic_island` tag, closes openstreetmap#633 * npm run build * add access field to: Park, Nat. Res., Sports Center/Club (closes openstreetmap#631) * add documented options for the crossing:markings tag from https://wiki.openstreetmap.org/w/index.php?title=Key:crossing:markings&oldid=2420133 * add translatable strings for crossing:markings values * Revert "add cuisine tag as optional field to supermarket preset, closes openstreetmap#623" This reverts commit 597d82d. * v5.0.0 * + changelog entry * bump dev version number * restore match score for entrances * add fields for diameter & height of wind turbines, closes openstreetmap#241 and also match features without `generator:method=wind_turbine` set, and suggest to add it * add missing caseSensitive property to many combo fields * drop field for (essentially) unused tag `water_volume` maybe this was intended for the tag `water_tank:volume`, but that one is also used pretty rarely on hydrants * Deploying to main from @ openstreetmap/id-tagging-schema@b1cb252 🚀 * add changelog for v5.0.1 * add some terms to the `man_made=bridge` preset (closes openstreetmap#634) * Add Team Handball Court preset (openstreetmap#636) * Deploying to main from @ openstreetmap/id-tagging-schema@f64a4bb 🚀 * Add Diving Platform preset (openstreetmap#637) * Deploying to main from @ openstreetmap/id-tagging-schema@fdb1683 🚀 * add term "bike parking" to the Bicycle Parking preset * Add Pipeline Substation preset (openstreetmap#640) * Add Pipeline Substation preset * Move pipeline=* presets to their own directory * Added unsearchable preset for pipeline=* * Add substation_pipeline field * Deploying to main from @ openstreetmap/id-tagging-schema@9cbea3f 🚀 * fix broken `npm run translations` command * upgrade schema-builder to v5.2 this updates transifex API access to v3, see also openstreetmap/iD#9375 * add `npm run dist translations` command and don't purge translations on `npm run dist` * npm run dist translations * update `roof:colour` field to new `colour` field type, closes openstreetmap#647 * add `cables` field to `power=[minor_]line` presets, closes openstreetmap#645 * allow Viewpoints to be mapped as areas, closes openstreetmap#650 * Add gantry presets (openstreetmap#649) * Add preset for `man_made=gantry` * Add presets for `power=portal` and `crane:type=*` Also added terms to Gantry preset and changed label from "Road Sign Structure" to "Gantry" * Apply suggestions from code review Co-authored-by: Martin Raifer <martin@raifer.tech> * Add strucutre_power field Also moved design to moreFields * Add structure_power field to power=tower preset Co-authored-by: Martin Raifer <martin@raifer.tech> * Deploying to main from @ openstreetmap/id-tagging-schema@5e3f07f 🚀 * Bump prettier from 2.7.1 to 2.8.0 (openstreetmap#651) Bumps [prettier](https://github.com/prettier/prettier) from 2.7.1 to 2.8.0. - [Release notes](https://github.com/prettier/prettier/releases) - [Changelog](https://github.com/prettier/prettier/blob/main/CHANGELOG.md) - [Commits](prettier/prettier@2.7.1...2.8.0) --- updated-dependencies: - dependency-name: prettier dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update maxstay options (openstreetmap#652) Wiki: The unit should not be abbreviated * currency values are case sensitive, fixes openstreetmap#654 https://wiki.openstreetmap.org/w/index.php?title=Key:currency&oldid=2436777 * require schema-builder v5.2.2 (with fix for openstreetmap#655) * expand * in terms, sort and add terms see openstreetmap#648 (comment) * Deploying to main from @ openstreetmap/id-tagging-schema@fffa81e 🚀 * fixed typo causing issue #9388 * Deploying to main from @ openstreetmap/id-tagging-schema@a1de17a 🚀 * v5.1.0 * add strings for documented values of `water_source` for Hydrants and drop the default value "main" (just because it's the most common value does not mean we can assume it is valid for every hydrant) * add missing values to crane type crane field (openstreetmap#662) * Deploying to main from @ openstreetmap/id-tagging-schema@6cc4f87 🚀 * fix match score for "generic" office presets (closes openstreetmap#661) fixes, e.g., the office preset disappearing for custom values * add preset for office=graphic_design (openstreetmap#664) * Deploying to main from @ openstreetmap/id-tagging-schema@2d67936 🚀 * add seamark tags to marine fuel & sewerage presets (openstreetmap#663) * add direction field to some presets (openstreetmap#665) also add some terms * Deploying to main from @ openstreetmap/id-tagging-schema@de9f210 🚀 * add preset for Variable Message Sign (openstreetmap#666) * Deploying to main from @ openstreetmap/id-tagging-schema@278e3e9 🚀 * restrict usage of Traffic Calming presets on lines/areas: * only traffic_calming=island is allowed to be mapped as an area * for traffic calming on lines: only allow it in combination with certain road presets. See https://wiki.openstreetmap.org/w/index.php?title=Key:traffic_calming&oldid=2438763#How_to_map * allow direction=forward/backward only on vertices see https://wiki.openstreetmap.org/w/index.php?title=Key:direction&oldid=2395441#Forward_and_backward * Deploying to main from @ openstreetmap/id-tagging-schema@ece16f8 🚀 * Add oneway field to cycleway crossing presets (closes openstreetmap#668, closes openstreetmap#667) * added shoes field and additional terms in shoe store preset (openstreetmap#669) * add missing markdown link * add missing key to `structure_power` field, fixes openstreetmap#676 * Deploying to main from @ openstreetmap/id-tagging-schema@29a0fc5 🚀 * add changelog entry for v5.1.1 backport/patch release * bump dev version * bump schema-builder to v5.3 * reduce duplicate translatable strings, closes openstreetmap#686 * Remove "line" geometry from lift gate (openstreetmap#679) Lift gates should only be nodes ([wiki](see https://wiki.openstreetmap.org/w/index.php?title=Tag:barrier%3Dlift_gate&oldid=2406647)). This line probably is the cause of a validation issue, where ID suggests converting an orphaned lift_gate node into a way instead of suggesting it to be added as a node to a way. * Only show direction_vertex_dual field on vertices (openstreetmap#684) * Replace field "site_type" with "archaeological_site", closes openstreetmap#677 also closes openstreetmap#680, closes openstreetmap#681, closes openstreetmap#682 * Deploying to main from @ openstreetmap/id-tagging-schema@f2eef8e 🚀 * cycleway field: use `no` value instead of `none`, fix spelling of labels * Add "GNIS Feature ID" field to waterway relation preset, closes openstreetmap#687 * Make name field for EV chargers optional, closes openstreetmap#688 and instead, promote the usage of the `brand` field also add `network` field (used on 15% of chargers) and remove `branch` field (which is currently not used in practice) * Add "waste disposal" as term to amenity=waste_disposal, closes openstreetmap#690 * Add terms to tanning salon, closes openstreetmap#691 * Deploying to main from @ openstreetmap/id-tagging-schema@64f8079 🚀 * Deploying to main from @ openstreetmap/id-tagging-schema@e3d8794 🚀 * Add translatable strings to craft type field (openstreetmap#692) Make common craft=* values (approx. > 1000 occurrences) translatable. * Deploying to main from @ openstreetmap/id-tagging-schema@13f1d02 🚀 * Add `layer=1` to addTags for Solar Panel Canopy (openstreetmap#689) * Fix typo: value for "Insulator" is `craft=insulation` (openstreetmap#695) * Deploying to main from @ openstreetmap/id-tagging-schema@d52ac4b 🚀 * Add Mobile Home Park preset (openstreetmap#696) * Deploying to main from @ openstreetmap/id-tagging-schema@57e0444 🚀 * Add `drive_through` as (optional) field to Cafe preset (openstreetmap#697) * Add `operator:type` field to park related presets (openstreetmap#698) * Add terms to Splashpad preset (openstreetmap#705) * In Houston they're called Water Spraygorunds * Also called Spraygrounds * Deploying to main from @ openstreetmap/id-tagging-schema@ab42b76 🚀 * add `material` as field to the (Utility) Marker preset, closes openstreetmap#704 see openstreetmap#704: > A significant distinguisher for many UK gas utility markers is colour (red vs yellow for national versus local) and material (concrete vs plastic). I have had to add these fields to markers on probably more than on thousand occasions over the last few months while trying to edit the UK in iD, so I thought it was about time I pushed this change so that I have to type less .... * Add translatable strings to traffic_calming type field (openstreetmap#699) the value `choked_island` was omitted for now, see https://github.com/openstreetmap/id-tagging-schema/pull/699/files#r1055517229 * Deploying to main from @ openstreetmap/id-tagging-schema@90358b0 🚀 * Add translatable strings to artwork_type field (openstreetmap#700) * Deploying to main from @ openstreetmap/id-tagging-schema@e6a5274 🚀 * Add translatable strings to board_type field (openstreetmap#701) * Deploying to main from @ openstreetmap/id-tagging-schema@199ac91 🚀 * add `notice` as a value of the `board_type` field * upgrade board_type=map to information=map see https://wiki.openstreetmap.org/w/index.php?title=Key:board_type&oldid=2431578 * Add translatable strings to bollard type field (openstreetmap#702) * Deploying to main from @ openstreetmap/id-tagging-schema@79e5752 🚀 * allow charging stations to be mapped as vertices, fixes openstreetmap#703 * fix typo * Deploying to main from @ openstreetmap/id-tagging-schema@0028715 🚀 * add covered as optional field to storage tank fixes openstreetmap#344 (comment) * [revert] remove covered field from generic storage tank preset This field is supposed to only be present on Water tanks, for which a dedicated preset exist (which I had overlooked at first). This partially reverts commit 769c4df. * resource label is "presets" not "preset" (openstreetmap#708) * Add translatable strings to basin type field (openstreetmap#710) * Deploying to main from @ openstreetmap/id-tagging-schema@a5c988c 🚀 * Add translatable strings to social_facility type field (openstreetmap#712) for common values with usage > 1,000 * Deploying to main from @ openstreetmap/id-tagging-schema@a972bf2 🚀 * Add translatable strings to utility type field (openstreetmap#713) * Deploying to main from @ openstreetmap/id-tagging-schema@9934b3e 🚀 * Create preset for residential garden (openstreetmap#714) There's a preset for community garden, but none for residential garden, which was very confusing for me. Adding one with some synonyms I found at Wikipedia. Co-authored-by: Martin Raifer <martin@raifer.tech>: only allow on areas: as this is extremely uncommon: currently only 100 out of 100k features with this tag are nodes: https://taginfo.openstreetmap.org/tags/garden%3Atype=residential * Deploying to main from @ openstreetmap/id-tagging-schema@ea2cf21 🚀 * add common independent physicians (openstreetmap#718) * revert accidental change of preset name in previous commit * Add trolleybus to Routes category (openstreetmap#724) * don't add "surface=grass" to Driving Ranges, fixes openstreetmap#727 instead: offer `surface` field * update taginfo project description, closes openstreetmap#726 * fix typo in (base) tag key https://wiki.openstreetmap.org/wiki/Tag%3Ahistoric%3Darchaeological_site * v5.2.0 release * bump dev version * add most popular alternative medicine practitioners (openstreetmap#731) * Deploying to main from @ openstreetmap/id-tagging-schema@36deeaa 🚀 * add `crossing:markings=yes` by default to Marked Crossings * suggest to add `crossing:markings=yes` to objects with `crossung=marked` * consolidate naming of marked crossings * reduce duplication of names * consistent use of "Crossing" vs. "Crosswalk" across similar presets * consistent use of terms * sort terms alphabetically * suggest `crossing:markings=no` for Unmarked Crossings * Revert "restrict usage of Traffic Calming presets on lines/areas:" This reverts commit 033e5f4. closes openstreetmap#733 * Deploying to main from @ openstreetmap/id-tagging-schema@3ff61df 🚀 * add release notes for v5.1.1 hotfix release * Add translatable strings to substance field (openstreetmap#737) Add translatable strings for values with usage > 1000. Left out are duplicate terms like wastewater, water waste, heat, steam. Co-authored-by: Martin Raifer <martin@raifer.tech> * Deploying to main from @ openstreetmap/id-tagging-schema@639c708 🚀 * Add translatable strings to material field (openstreetmap#735) * Deploying to main from @ openstreetmap/id-tagging-schema@b8ecd5e 🚀 * Add translatable strings to memorial field (openstreetmap#734) * Deploying to main from @ openstreetmap/id-tagging-schema@63dbb6a 🚀 * Add translatable strings to barrier type field (openstreetmap#709) * Deploying to main from @ openstreetmap/id-tagging-schema@2714e45 🚀 * Add translatable strings to archaeological_site type field (openstreetmap#707) * Deploying to main from @ openstreetmap/id-tagging-schema@584720a 🚀 * fix typo (glas -> glass) * Deploying to main from @ openstreetmap/id-tagging-schema@4c1d405 🚀 * add "cannabis dispensary" as search term to "shop=cannabis", see openstreetmap#739 * add missing markdown link * Add translatable strings to bath:type field (openstreetmap#742) * Deploying to main from @ openstreetmap/id-tagging-schema@ad23396 🚀 * fields/parking: centerline parking and orientation …for case :left, :right, :both. The directionalCombo will show left/right in separate fields when both is present and merge/split the side as needed. Allow tagging `parking:$side` and `parking:$side:orientation` on centerlines (highways). * Update source_strings.yaml * update field to final v6 schema * upgrade to schema-builder v6 * update field to final v6 schema * Deploying to main from @ openstreetmap/id-tagging-schema@b3beba8 🚀 * Deploying to main from @ openstreetmap/id-tagging-schema@9391e2f 🚀 * parking field: Add values on_kerb, half_on_kerb, shoulder (openstreetmap#672) Following the successful proposal https://wiki.openstreetmap.org/wiki/Proposed_features/street_parking_revision#Summary:_What_is_proposed,_changed_and_deprecated? those keys are suggested for separately mapped parking areas. Since this field has `autoSuggestions` and `customValues` off they are listed all, even if not very common. * Deploying to main from @ openstreetmap/id-tagging-schema@b7127e5 🚀 * Create picnic_table.json Can be used for several tourism related features. Also see openstreetmap#736 * Create tents.json * Update tents.json * Update tents.json * Create caravans.json Key is used with tourism related features. Also see openstreetmap#26 * Create static_caravans.json Key is used with tourism related features. Also see openstreetmap#26 * Create nudism.json Key used with tourism or leisure related features. Also see openstreetmap#26 * Make natural wood points unsearchable (openstreetmap#755) * Add field for `lift_gate:type` (openstreetmap#711) * Deploying to main from @ openstreetmap/id-tagging-schema@720d973 🚀 * Deploying to main from @ openstreetmap/id-tagging-schema@06e2375 🚀 * Add translatable strings to sport field (openstreetmap#747) Add translatable strings to sport field for values with usage > 5000 * leaving out `multi`, as the [intended use](https://wiki.openstreetmap.org/wiki/Tag%3Asport%3Dmulti) is rather complex and not really fitting to the simple field type used here. Leaving it untranslated is IMHO better, as the rendering as a raw tag conveys the concept that this is something more specific going on. Co-authored-by: Martin Raifer <martin@raifer.tech> * Deploying to main from @ openstreetmap/id-tagging-schema@c1c0a64 🚀 * Add translatable strings to attraction field (openstreetmap#756) * Add translatable strings to attraction field for values with usage > 500 * add entries for existing presets * add value for alpine_coaster Co-authored-by: Martin Raifer <martin@raifer.tech> * Deploying to main from @ openstreetmap/id-tagging-schema@c4af856 🚀 * rename to "Ferris Wheel" * use Röntgen icons for crane types * specify icons for crossing markings * Add translatable strings to waste field (openstreetmap#758) * Deploying to main from @ openstreetmap/id-tagging-schema@b49ad3b 🚀 * Add translatable strings to office field (openstreetmap#761) for values with usage > 1000 and existing sub-presets * Add translatable strings to resource field (openstreetmap#760) * allow to specify therapist offices more precisely * Deploying to main from @ openstreetmap/id-tagging-schema@530bcd2 🚀 * Deploying to main from @ openstreetmap/id-tagging-schema@4796398 🚀 * Deploying to main from @ openstreetmap/id-tagging-schema@fe6bd58 🚀 * add term * change field type for date fields * v6.0.0 release candidate 1 Signed-off-by: Martin Raifer <martin@raifer.tech> * Add translatable strings to clothes field (openstreetmap#763) For values with usage > 150 * Deploying to main from @ openstreetmap/id-tagging-schema@292133f 🚀 * add a few more values for the `clothes` field * Add translatable strings to building field (openstreetmap#764) For values already supported by iD as preset * Deploying to main from @ openstreetmap/id-tagging-schema@9490ffe 🚀 * add more values for building field * also show "military bunker" fields for building=bunker objects * Add ref field to Sports Pitch preset (openstreetmap#766) * Create engineer.json (openstreetmap#767) Closes openstreetmap#639 * Deploying to main from @ openstreetmap/id-tagging-schema@ff7bc92 🚀 * "ore" is not misspelled * sort * use Röntgen icon for more presets and field-values presets: * Diving Platform * City Limit Sign * Turning Loop fields values: * `design` field of Power Poles and Power Towers/Portals * `leaf_type` * `traffic_calming` * `volcano:type` and `volcano:status` * `tower:construction` * mark `design` field as "manual" as it is not used by presets directly, but only other fields. solves corresponding validation warnings * Add preset for shop=nuts (openstreetmap#774) * Deploying to main from @ openstreetmap/id-tagging-schema@3e30f1d 🚀 * Add more fields to highway=rest_area (openstreetmap#773) * Deploying to main from @ openstreetmap/id-tagging-schema@418b90c 🚀 * fix typo * Deploying to main from @ openstreetmap/id-tagging-schema@a677d7f 🚀 * Fix typo (openstreetmap#788) Re: openstreetmap@a677d7f#commitcomment-100379518 * Deploying to main from @ openstreetmap/id-tagging-schema@38da1af 🚀 * Move `access_simple` to main fields for AEDs (openstreetmap#786) * Allow landuse=industrial to be mapped as a point (openstreetmap#776) * fix presets with dupliate ids * merge duplicate barrier=ditch presets * give unique ids to alternate "point geometry" presets for natural=wood and landuse=industrial * allow Cemeteries to be mapped as points * Create staircase.json (openstreetmap#775) * Deploying to main from @ openstreetmap/id-tagging-schema@405e875 🚀 * use Röntgen icons for (water) slides * Add terms (polo/rodeo) for sport=equestrian preset (openstreetmap#780) Also renamed preset to 'Horseback Riding / Rodeo Arena' * Deploying to main from @ openstreetmap/id-tagging-schema@33baf3a 🚀 * add regional & universal field for ref:linz:place_id (openstreetmap#781) * these terms are now misspelled * add railway route to categories (openstreetmap#782) * add preset for turntable (openstreetmap#783) * Deploying to main from @ openstreetmap/id-tagging-schema@c9b4fb2 🚀 * allow advertising presets as a line & add `message` field (openstreetmap#785) * Deploying to main from @ openstreetmap/id-tagging-schema@0b60a7f 🚀 * add preset for "other" advertising devices * Add Senior Assisted Living Facility preset (openstreetmap#787) * Deploying to main from @ openstreetmap/id-tagging-schema@119f288 🚀 * Update deprecated.json (openstreetmap#777) * hide "street_cabinet" field; add presets for special cabinets after openstreetmap#777, unfortunately, there were two fields to define the sub-type of street cabinets: utility for the "common" ones (e.g. telecom, power, etc.) and the "legacy" street_cabinet field for the rest. This PR adds dedicated presets for the legacy cases where the "street_cabinet" tag is still to be used to solve this UI issue. * Deploying to main from @ openstreetmap/id-tagging-schema@ec2a8dd 🚀 * add presets for Psychiatrist and Child Psychiatrist closes openstreetmap#778 * add an additional search term * Deploying to main from @ openstreetmap/id-tagging-schema@63483a7 🚀 * Deploying to main from @ openstreetmap/id-tagging-schema@1f916b0 🚀 * fix typo (openstreetmap#791) * Deploying to main from @ openstreetmap/id-tagging-schema@45494b8 🚀 * make clear that `shop=pet_grooming` is for pet groomer (openstreetmap#790) * Deploying to main from @ openstreetmap/id-tagging-schema@05d699c 🚀 * create preset for Depots (`industrial=depot`) (openstreetmap#784) * Deploying to main from @ openstreetmap/id-tagging-schema@6b1b44b 🚀 * Add preset for amenity=stripclub (openstreetmap#648) * Deploying to main from @ openstreetmap/id-tagging-schema@c77bc90 🚀 --------- Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Martin Raifer <martin@raifer.tech> Co-authored-by: tyrasd <martin@raifer.tech> Co-authored-by: archpdx <archpdx@pm.me> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Kamil Monicz <kamil@monicz.pl> Co-authored-by: alanb43 <ab43work@gmail.com> Co-authored-by: Kyℓe Hensel <k-yle@users.noreply.github.com> Co-authored-by: Kyle Hensel <k.y.l.e@outlook.co.nz> Co-authored-by: kjonosm <51236777+kjonosm@users.noreply.github.com> Co-authored-by: Jeremy Abapo <55824592+jdabapo@users.noreply.github.com> Co-authored-by: Michael <30999326+Discostu36@users.noreply.github.com> Co-authored-by: Evan Carroll <me@evancarroll.com> Co-authored-by: kesterlester <cgl20@cam.ac.uk> Co-authored-by: Mateusz Konieczny <matkoniecz@gmail.com> Co-authored-by: Mikael Dúi Bolinder <github@bolinder.uk> Co-authored-by: Tobias Zwick <newton@westnordost.de> Co-authored-by: Tobias <tobias@fixmycity.de> Co-authored-by: Flo Edelmann <git@flo-edelmann.de> Co-authored-by: Lonerat <118647831+Lonerat@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's something wrong with the office preset, presumably it's the result of #399.
If you create an area with
building=yes+office=some_popular_value_that_has_no_preset, then iD will show the generic building preset, not the generic office preset.To fix this I've changed the match scores so that they're higher than building (0.5) but lower than most other presets