Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parking/orientation: update and deprecate key #673

Merged
merged 2 commits into from
Mar 31, 2023

Conversation

tordans
Copy link
Collaborator

@tordans tordans commented Dec 8, 2022

This PR is for next week when the voting was officially concluded. — Update: The proposal was accepted. All related documentation is updated and the manual data migration is on it's way.


Following the successful street parking revision proposal https://wiki.openstreetmap.org/wiki/Proposed_features/street_parking_revision#Summary:_What_is_proposed,_changed_and_deprecated? the tag for orientation on separately mapped parking spaces is now just orientation.

Regarding separately mapped parking areas, (…)
parking:orientation=* will be deprecated and replaced by orientation=*(…)


I added duplicated the deprecation rule for orthogonal to handle both the old and new key because I was not sure about the order (cardinality) of the rules / if the key deprecation would then in turn still trigger the value deprecation. Having all three should not be an issue I guess.


FYI @SupaplexOSM


Update:

  • Decide how to handle the folder. It is fields/parking/orientation.json right now. Following the tag convention, we should move it to fields/orientation.json. However, maybe we should move all parking related fields to this folder instead (especially fields/parking.json? I think that would be a good idea so its to see the parking-scope in the preset-jsons.

Following the successful street parking revision proposal https://wiki.openstreetmap.org/wiki/Proposed_features/street_parking_revision#Summary:_What_is_proposed,_changed_and_deprecated? the tag for orientation on separately mapped parking spaces is now just `orientation`.
@tyrasd tyrasd added waitfor-discussion a discussion in the osm community (e.g. a tag proposal) is required before this can be worked on enhancement New feature or request deprecating labels Dec 8, 2022
@tyrasd
Copy link
Member

tyrasd commented Dec 8, 2022

Decide how to handle the folder.

I'd prefer if a <key>:<subkey> tag actually end up as a field in key/subkey.json. Yes, it would make sense to also include other related tags in the same directory, but these should then get a <key>_<discriminator>.json file name. Hmm… maybe here something like orientation_parking.json could work?!

@tordans
Copy link
Collaborator Author

tordans commented Dec 28, 2022

@tyrasd I move the field to fields/orientation/orientation_parking.json. I could move it to fields/orientation_parking.json, if you prefer.

I also updated the PR description, since the proposal is accepted and all docs are updated. The data migration is already going strong.

@tyrasd tyrasd removed the waitfor-discussion a discussion in the osm community (e.g. a tag proposal) is required before this can be worked on label Jan 17, 2023
@Zaczero
Copy link
Contributor

Zaczero commented Feb 28, 2023

This tag is now officially deprecated but iD keep on using it. What's the blocker here?

@tordans
Copy link
Collaborator Author

tordans commented Mar 19, 2023

@tyrasd I think this can be merged.

We where asked about this recently osmberlin/parkraum.osm-verkehrswende.org#30 (comment)

@tyrasd tyrasd merged commit 1510769 into openstreetmap:main Mar 31, 2023
@tordans tordans deleted the parking_separate_orientation branch March 31, 2023 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deprecating enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants