Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UK specific Post Box tagging. #804

Merged
merged 9 commits into from Mar 1, 2023
Merged

Conversation

UKChris-osm
Copy link
Contributor

@UKChris-osm UKChris-osm commented Mar 1, 2023

#670 @boothym

Added location exclusion to the current post box file, excluding gb.
Added new file for a gb post box to promote gb specific tagging.

@UKChris-osm
Copy link
Contributor Author

I took post_box:type from the the wiki, but I see it's causing a build error, is that an error on my part?

Copy link
Member

@tyrasd tyrasd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The definition of the two new fields (post_box:type and royal_cypher) are still missing in this PR.

They should probably both by of "type": "combo", I assume.

data/presets/amenity/post_box/post_box_gb.json Outdated Show resolved Hide resolved
data/presets/amenity/post_box/post_box_gb.json Outdated Show resolved Hide resolved
@tyrasd
Copy link
Member

tyrasd commented Mar 1, 2023

PS: The missing fields should go into data/fields, see https://github.com/openstreetmap/id-tagging-schema/blob/main/data/fields/piste/type.json for an example of a similar combo field.

PSS: I like that you put the regional preset into a new subdirectory (data/presets/amenity/post_box/). But could you please rename the file to post_box-GB.json, following the naming convention we use for regional presets.

@UKChris-osm
Copy link
Contributor Author

I've tried applying the suggested changes, hopefully I have done so accurately.

@UKChris-osm
Copy link
Contributor Author

Thanks for helping me through this @tyrasd, sorry for my syntax errors.

@tyrasd tyrasd merged commit 5014680 into openstreetmap:main Mar 1, 2023
@UKChris-osm UKChris-osm deleted the post-box branch March 1, 2023 21:31
@tyrasd
Copy link
Member

tyrasd commented Mar 1, 2023

No worries. Thanks for your first PR to the tagging schema! 😃

@UKChris-osm
Copy link
Contributor Author

How long until this tagging will be usable within iD?

closes #670

@tyrasd
Copy link
Member

tyrasd commented Mar 1, 2023

Not long. I've been planning to do a proper release for 6.0 soon anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants