-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UK specific Post Box tagging. #804
Conversation
I took |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The definition of the two new fields (post_box:type
and royal_cypher
) are still missing in this PR.
They should probably both by of "type": "combo"
, I assume.
PS: The missing fields should go into PSS: I like that you put the regional preset into a new subdirectory ( |
I've tried applying the suggested changes, hopefully I have done so accurately. |
…if name is referenced from another preset see https://github.com/ideditor/schema-builder#name
Thanks for helping me through this @tyrasd, sorry for my syntax errors. |
No worries. Thanks for your first PR to the tagging schema! 😃 |
How long until this tagging will be usable within iD? closes #670 |
Not long. I've been planning to do a proper release for 6.0 soon anyway. |
#670 @boothym
Added location exclusion to the current post box file, excluding gb.
Added new file for a gb post box to promote gb specific tagging.