Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable tagging unspecific crossing #837

Merged
merged 3 commits into from Apr 4, 2023
Merged

Conversation

matkoniecz
Copy link
Contributor

fixes #834

@github-actions
Copy link

🍱 Preview the tagging presets of this pull request here: https://pr-837--ideditor-presets-preview.netlify.app/id/dist/#locale=en.

@matkoniecz
Copy link
Contributor Author

#834 (comment) points out serious issue - it is also correct for cases where cycleway crosses road and maybe even where footway crosses cycleway

@matkoniecz matkoniecz marked this pull request as draft March 25, 2023 19:58
@tyrasd tyrasd marked this pull request as ready for review March 28, 2023 16:30
@tyrasd tyrasd added the enhancement New feature or request label Mar 28, 2023
@tyrasd tyrasd self-assigned this Mar 28, 2023
@tyrasd
Copy link
Member

tyrasd commented Mar 28, 2023

Yeah… just calling it "Crossing" should be better here, as that accommodates both foot and bike crossings. I've adapted the PR accordingly. I've also added a few additional search terms and enabled the crossing fields as optional moreFields (such that if a crossing is mapped with, e.g. a crossing:island tag, but without crossing=*, the information is not hidden from the mapper).

What do you think?

@matkoniecz
Copy link
Contributor Author

crossing:signals tag seems to be not shown

optional moreFields (such that if a crossing is mapped with, e.g. a crossing:island tag, but without crossing=*, the information is not hidden from the mapper).

What about making them appear already when not tagged (at least crossing signals one) to encourage mapper to answer them?

@tyrasd tyrasd merged commit bb084d7 into openstreetmap:main Apr 4, 2023
5 checks passed
@matkoniecz matkoniecz deleted the patch-6 branch April 4, 2023 14:29
@1ec5 1ec5 mentioned this pull request Oct 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow tagging crossing without specifying variety (just highway=crossing)
2 participants