Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

try more dedicated icon for sign maker #839

Merged
merged 3 commits into from Mar 27, 2023
Merged

try more dedicated icon for sign maker #839

merged 3 commits into from Mar 27, 2023

Conversation

matkoniecz
Copy link
Contributor

@matkoniecz matkoniecz commented Mar 25, 2023 •
edited

see #41

@github-actions
Copy link

🍱 Preview the tagging presets of this pull request here: https://pr-839--ideditor-presets-preview.netlify.app/id/dist/#locale=en.

@matkoniecz
Copy link
Contributor Author

matkoniecz commented Mar 25, 2023 •
edited

Sadly, it has not worked. Not sure why.

Tried to use https://fontawesome.com/icons/signs-post?f=classic&s=solid

@matkoniecz matkoniecz mentioned this pull request Mar 25, 2023
Closed
@matkoniecz matkoniecz changed the title try more dedicated icon (#41) try more dedicated icon for sign maker Mar 25, 2023
@matkoniecz matkoniecz marked this pull request as draft March 25, 2023 17:01
@matkoniecz matkoniecz mentioned this pull request Mar 25, 2023
Merged
@matkoniecz matkoniecz marked this pull request as ready for review March 27, 2023 17:03
@matkoniecz
Copy link
Contributor Author

screen

@matkoniecz
Copy link
Contributor Author

Thanks so much for the fix!

@tyrasd
Copy link
Member

tyrasd commented Mar 27, 2023 •
edited

I'm wondering whether https://fontawesome.com/icons/sign-hanging?f=classic&s=solid would be even more fitting?

@matkoniecz
Copy link
Contributor Author

yes, seems better as it is far more likely that they will make one looking like this

@tyrasd tyrasd merged commit 6a5779d into openstreetmap:main Mar 27, 2023
5 checks passed
@matkoniecz matkoniecz deleted the patch-9 branch March 27, 2023 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@matkoniecz @tyrasd