Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Presets: Two specific tree presets #956

Merged
merged 5 commits into from
Jul 21, 2023
Merged

Presets: Two specific tree presets #956

merged 5 commits into from
Jul 21, 2023

Conversation

tordans
Copy link
Collaborator

@tordans tordans commented Jul 12, 2023

Most trees in Europe tend to fall into one of the two categories

  • Broadleaved Tree (deciduous)
  • Needleleaved Tree (evergreen)

There are cases, where this is not true, of course, but in my experience the majority fits into those two groups.

Those two specific presets would make it a lot easier to add a tree of those groups and apply all needed tags in one go. Variations are also easier to change, eg. when only leaf_cycle needs to change to semi_evergreen.


My overall goal is, to be able to type "laubbaum" in GoMap and have all tree tags filled out…


Open questions:

@tordans

This comment was marked as resolved.

@github-actions
Copy link

🍱 Preview the tagging presets of this pull request here: https://pr-956--ideditor-presets-preview.netlify.app/id/dist/#locale=en.

This is more consistent with the default icon for presets/tree but also maki-park is the better broadleaved tree, especially when rendered as a small map pin.
@tordans
Copy link
Collaborator Author

tordans commented Jul 12, 2023

Update: I change to use maki-park for broadleaved trees since that icon looks better then roetgen and it is more consistent.

image Bildschirm­foto 2023-07-12 um 22 29 54

@tordans
Copy link
Collaborator Author

tordans commented Jul 12, 2023

New question @tyrasd : How do I get the preset to render the leave_cycle and leaf_type field for the new presets even though those are part of the tags object?

Right now it looks like this (Link)… which makes it hard to change the given settings for leave_cycle and leaf_type.

Bildschirm­foto 2023-07-12 um 22 30 17

@tyrasd
Copy link
Member

tyrasd commented Jul 12, 2023

just add the fields again to the individual presets: they are only omitted in the inherited/referenced fields from other presets (and also present as tags of the preset), but kept if directly included in the fields list.

@tordans
Copy link
Collaborator Author

tordans commented Jul 13, 2023

  • How does the search priority work

I think that is fine as is…

image

@tordans
Copy link
Collaborator Author

tordans commented Jul 13, 2023

  • Do the icons look good

I think this looks good now…

image

@tordans
Copy link
Collaborator Author

tordans commented Jul 13, 2023

@tyrasd thanks. This is ready for review, now :)

PS: I created two PRs in the schema repo to improve the docs. https://github.com/ideditor/schema-builder/pulls/tordans

@tyrasd
Copy link
Member

tyrasd commented Jul 17, 2023

I've added (for now unsearchable) presets for the not-so-common-but-still-possible combinations (needleleaved+deciduous & broadleaved+evergreen) and the leaf-type-only versions. This should make the mapping more seamless when dealing with existing data or manually selecting the respective values, and will show the correct icon for all trees with a mapped leaf_type=broadleaved/needleleaved . Also, I've changed the icon for the generic Tree preset, such that it is visually different in the presets list and on the map.

What do you think?

Copy link
Collaborator Author

@tordans tordans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update @tyrasd.

I was holding back on adding more detailed presents to not overwhelm the translators. But given how many trees we have in OSM, adding those presents makes it a lot clearer, so that is good!

I still do not like the roentgen-tree icon inside the map in. It looks like an ice cream cone to me. However, given having the general preset different from the more precise presets is good idea. Ideally we would have a "left leaves, right needle" icon in temaki.

I saw that a few of the unsearchable presets did not have the unsearchable flat. I will add this after submitting this comment.


Offtopic: It's worth mentioning this nice tree rendering discovery https://imagico.de/blog/en/a-new-design-for-tree-rendering-in-digital-maps/ – even though it does not directly relate to this PR.

data/presets/natural/tree/_needleleaved.json Outdated Show resolved Hide resolved
data/presets/natural/tree/needleleaved/_deciduous.json Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants