Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add field for opening_hours:drive_through=* #999

Merged
merged 3 commits into from Dec 16, 2023

Conversation

arch0345
Copy link
Contributor

@arch0345 arch0345 commented Sep 8, 2023

Many establishments with drive throughs have different opening hours compared to their normal opening hours. For example, this Krispy Kreme location has their drive through open 24/7 while the inside of their shop is only open during certain hours.

@github-actions
Copy link

github-actions bot commented Sep 8, 2023

🍱 Preview the tagging presets of this pull request here: https://pr-999--ideditor-presets-preview.netlify.app/id/dist/#locale=en.

@kjonosm
Copy link
Contributor

kjonosm commented Sep 8, 2023

@arch0345 Is it possible to only show this field when drive_through=yes has been added?

@arch0345
Copy link
Contributor Author

arch0345 commented Sep 8, 2023

@arch0345 Is it possible to only show this field when drive_through=yes has been added?

Yes, I added drive_through=yes as a prerequisiteTag:

"prerequisiteTag": {
"key": "drive_through",
"value": "yes"
},

Copy link
Member

@tyrasd tyrasd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tag is not quite super popular right now, but the trajectory is pointing steeply upwards, so 👍 from my side to include it. See one possible improvement suggestion below; let me know what you think about that.

data/fields/opening_hours/drive_through.json Outdated Show resolved Hide resolved
Co-authored-by: Martin Raifer <martin@raifer.tech>
@tyrasd tyrasd added waitfor-info something is unclear with the suggestion, more information is needed to evaluate this feature reques and removed waitfor-info something is unclear with the suggestion, more information is needed to evaluate this feature reques labels Dec 16, 2023
@tyrasd tyrasd merged commit 8ee33f2 into openstreetmap:main Dec 16, 2023
5 checks passed
@arch0345 arch0345 deleted the opening_hours branch January 24, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants