:wikipedia bug

[UKChris-osm]

iD seems to now be suggesting to add empty ":wikipedia" tags for NSI items. These tags were removed a long time ago, so I'm not sure why iD is now suggesting to add empty ones?

Ref: osmlab/name-suggestion-index#9284

[arch0345]

This seems to be caused by 4829f8a

[UKChris-osm]

This seems to be caused by 4829f8a

Yes, that's what I'm thinking - so not something we can fix from the NSI end?

[UKChris-osm]

if (preset.tags['brand:wikidata']) { preset.addTags['brand:wikipedia'] = ''; }

... the code seems to be checking for a :wikidata tag, and just adding an empty :wikipedia tag to the item - was this intentional?

[tyrasd]

adding an empty :wikipedia tag to the item - was this intentional?

yes, this was intentional, as you can read in the source code comment:

nsi does not specify *:wikipedia (anymore):
clean up previous values to prevent that the wikidata/wikipedia information
is going to be out of sync, see #9103

I went with the fix proposed in #9103 (comment), but unfortunately this introduced/triggered a bug in the validation module, which no one found before the release. It should not be too hard to fix, though.

[tyrasd]

FYI: I created a patch release (v2.28.1) for this: see openstreetmap/openstreetmap-website#4551