Improve lock contention in render_list etc #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| cmd->z = e->z; | ||
| cmd->x = e->x; | ||
| cmd->y = e->y; | ||
| strncpy(cmd->xmlname, e->mapname, XMLCONFIG_MAX - 1); |
Check notice
Code scanning / Flawfinder
Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). Note
There was a problem hiding this comment.
Since this existing code with no changes except indentation and position, I don't think CWE-120 is a blocker.
tomhughes
force-pushed
the
queue-concurrency
branch
from
1d57ee1
to
cc4ee08
Compare
pnorman
approved these changes
Sep 21, 2023
| cmd->z = e->z; | ||
| cmd->x = e->x; | ||
| cmd->y = e->y; | ||
| strncpy(cmd->xmlname, e->mapname, XMLCONFIG_MAX - 1); |
There was a problem hiding this comment.
Since this existing code with no changes except indentation and position, I don't think CWE-120 is a blocker.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This attempts to minimise the time that the lock is help when taking a job from the queue and scales the queue size with the number of threads to try and ensure it stays full enough to keep all threads busy.