Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSRM routing directions displayed in English regardless of 'ru' setting in user profile or HTTP Accept-Language #1047

Closed
d1g opened this issue Aug 29, 2015 · 8 comments

Comments

@d1g
Copy link

d1g commented Aug 29, 2015

Client-side issue but I'm not sure if this is right place to report this bug.

Case 1 (en user, ok):

  1. open account settings (current route /user/xxx/account, user-agnostic route here would be more useful btw)
  2. set 'Preferred Languages' to 'en'
  3. open http://www.openstreetmap.org/directions?engine=osrm_car&route=48.85715%2C2.33652%3B48.85652%2C2.33818
  4. "Directions" is in English. "Turn left onto" is also in English

Case 2 (fr user, ok):

  1. same
  2. set 'Langues préférées' to 'fr'
  3. same
  4. "Itinéraire" is in French. "Tourner à gauche sur" is also in French

Case 3 (ru user, bug):

  1. same
  2. set 'Предпочитаемые языки:' to 'ru'
  3. same
  4. "Маршрут" is in Russian. "Turn left onto" is in English (!), expected: "Примите влево на"

Link to OSRM query.

@d1g
Copy link
Author

d1g commented Aug 29, 2015

Also, setting preferred languages to 'RU', 'ru_RU' or 'ru_ru' results in 'en' page ('Directions', but not 'Маршрут'). Probably we want less error-prone input field for 'preferred languages' (multiselect)

@tomhughes
Copy link
Member

Well do translations actually exist for those strings? If they don't we will fall back to english...

@tomhughes
Copy link
Member

As I suspected there is no translation present for that string in our Russian locale.

See http://wiki.openstreetmap.org/wiki/Website_Internationalization#How_to_translate for more information on how to help out with translation.

Language matching follows normal HTTP rules, and there shouldn't normally be any need to edit that field at all as we capture it from the browser when you sign up.

@d1g
Copy link
Author

d1g commented Aug 29, 2015

no translation present for that string in our Russian locale.

@tomhughes, well but http://map.project-osrm.org/ was translated in Russian (and 25 languages in total). Wouldn't it be better to reuse strings from project-osrm?

Well do translations actually exist for those strings?
no translation present for that string in our Russian locale.

Do you mean in source code or translation platform?
"Turn left onto" was translated 7 days ago.

@tomhughes
Copy link
Member

No, it can take a few weeks before translations are pushed back to openstreetmap and there hasn't been a sync for a about a month now, probably because people have been away over the summer.

@d1g
Copy link
Author

d1g commented Aug 29, 2015

and there hasn't been a sync for a about a month now, probably because people have been away over the summer

@tomhughes, does it mean that you are not the person responsible for this and we cannot update strings sooner? Is there anything we can do about it?

@tomhughes
Copy link
Member

No, the TranslateWiki folks push the changes from their end.

@d1g
Copy link
Author

d1g commented Aug 29, 2015

@tomhughes, thanks for info! Probably it should be stated at http://wiki.openstreetmap.org/wiki/Website_Internationalization#How_to_translate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants