Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

map page: unfocus search bar when pressing '-' or '+' #1629

Closed
zepatrik opened this issue Sep 3, 2017 · 3 comments
Closed

map page: unfocus search bar when pressing '-' or '+' #1629

zepatrik opened this issue Sep 3, 2017 · 3 comments

Comments

@zepatrik
Copy link

zepatrik commented Sep 3, 2017

I don't know about you but when I load the map page the first thing I do is zoom out to go to the desired location or search for it. The second use case is comfortably handled by the autofocused input, but for the first one the map has to be in focus. So why not make an exception when starting to type with a - or + so the zoom function of those buttons is conserved while still allowing to search right away? I don't think there is any use case you would want to start a search with those two symbols.

@tomhughes
Copy link
Member

Seems like an extremely niche use case and extremely confusing behaviour if some keys cause the focus to change in mysterious ways instead of inputting into the field that has focus.

I don't know about you, but I basically never use use the +/- buttons, and I certainly never trigger them from the keyboard like that - in fact I didn't even know you could! I either zoom using the mouse wheel (or touchpad equivalent) or by shift-dragging to zoom in.

@HolgerJeromin
Copy link
Contributor

HolgerJeromin commented Sep 4, 2017

My baby aged daughter showed me that i can use the cursor keys to move the map :-)

But magic focus handling would be surprising for me. Probably we should not open that can of worms.

@zepatrik
Copy link
Author

zepatrik commented Sep 5, 2017

Actually, what would you expect to happen when you use the - or + keys? - zoom
Regardless of what's focused because your brain focuses the map and not the search bar. If you want to search for something you go to the input. Having the input focused on load is maybe convenient because some people might want that and something has to be focused, so why not the search bar. When you use the mouse to navigate the map the focus changes anyways, but the keys for navigating are not supported on load. And that behavior is unexpected, I think. Nobody pressing the zoom keys would even notice "magic focus handling" because in the brain the map is already focused.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants