Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Email links in text/plain ending in "." - break links #1844

Open
flohoff opened this issue May 2, 2018 · 3 comments
Open

Email links in text/plain ending in "." - break links #1844

flohoff opened this issue May 2, 2018 · 3 comments

Comments

@flohoff
Copy link

flohoff commented May 2, 2018

Hi,

i am reading my emails with mutt in a terminal emulator and most(all?) OSM notification mails for Changeset comments etc contain the link ended with a "." for a correct sentence ending. The problem is that the default url regexp for all terminal emulators takes the dot "." with them.

All emails with multipart/alternative in their text/plain part should have a space between a url and the following text/template parts that urls stay detectable by terminal emulators:

Part of this problem has been discussed in #995

Here an example from an email i just got:

More details about the changeset can be found at https://www.openstreetmap.org/changeset/58362330.

To unsubscribe from updates to this changeset, visit https://www.openstreetmap.org/changeset/58362330 and click "Unsubscribe".
@tomhughes
Copy link
Member

As discussed in #995 there is really no good solution for this - it is always going to be hit or miss whether any particular client manages to guess how to extract a link from plain text which is why we include an HTML version of the message where the boundaries are clear.

Short of rewriting sentences to avoid having links at the end, which may be very clumsy and in any case will be subject to breakage in each translation if translators move them around do you actually have a suggested solution?

@flohoff
Copy link
Author

flohoff commented May 2, 2018

The point is that "." is a valid character for a URL - So ending a URL with a "." is valid. There can be no automated system which knows if the "." belongs to the URL or not. Its just us - the human beeings - looking at the osm urls beeing able to distinguish. The only valid character to end a url is a space because that is actually an invalid character (would need to be encoded as %20)

@tomhughes
Copy link
Member

Yes but it's virtually impossible for us to guarantee a space after a URL for several reasons.

Firstly because it may just not make sense in terms of the sentence structure and secondly because even if I change all the english text to avoid having URLs at the end of sentences I have no way to ensure that translators won't undo that in other translations. There's no practical way to prevent that happening when the translations are crowdsourced.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants