Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

notes feature. A few cosmetic tweaks #235

Closed
harry-wood opened this issue Apr 26, 2013 · 6 comments
Closed

notes feature. A few cosmetic tweaks #235

harry-wood opened this issue Apr 26, 2013 · 6 comments

Comments

@harry-wood
Copy link
Contributor

I want to get a screenshot of the new notes feature (bubble view e.g. http://www.openstreetmap.org/?note=123 ) for a blog post going out soon, but there's a couple of cosmetic things which seem a bit ugly.

The note text itself doesn't seem prominent enough for various reasons:

The title at the top of a notes bubble, giving the numeric ID of a note. Maybe get rid of this entirely? It's only use at the moment is for permalinking the note. Maybe we could have a little grey 'permalink' instead? ...or at least make the title much smaller and less prominent.

Anonymous postings come with a bright red background warning. This seems a bit over the top. It's only a relatively minor warning surely. Make it light grey background with a dinky little warning symbol (warning) instead.

When a reply / follow up comment is present, there needs to tad more vertical space, perhaps even a line to give some separation.

@ajashton
Copy link

The CSS could also be tweaked slightly to match the other controls on the site. Reduce the border-radius to 2px and box-shadow radius to 4px? I've also tried light yellow as the warning background.

@tomhughes
Copy link
Member

Well that's just the standard leaflet styling I think @ajashton so we would have to be careful to work out what else would be affected.

@tomhughes
Copy link
Member

I think my original plan for the warning was to use the same colour we use for flash warning messages, but that is #fff6f0 which is so pale it is basically invisible on a white background (which is a bit worrying for flash messages...) so I went with the error colour of #ff7070 instead.

@tomhughes
Copy link
Member

I've increased the space between comments (e2b364d), reduced the radius on the corners to match what we were already doing for leaflet popups on the user maps (4a69512) and replaced the title with a permalink (d48b1cc).

@tomhughes
Copy link
Member

I've now toned down the warning as well, in a14abfe.

@tomhughes
Copy link
Member

I think all the points raised here have been addressed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants