Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cancel button on terms page doesn't do anything #2514

Open
simonpoole opened this issue Jan 18, 2020 · 5 comments
Open

Cancel button on terms page doesn't do anything #2514

simonpoole opened this issue Jan 18, 2020 · 5 comments

Comments

@simonpoole
Copy link
Contributor

Probably an error I built in, will investigate.

@simonpoole
Copy link
Contributor Author

OK "not my fault". The button should open a wiki page but hits a CSP issue

terms:1 Refused to send form data to 'https://wiki.openstreetmap.org/' because it violates the following Content Security Policy directive: "form-action 'self'".

@tomhughes
Copy link
Member

Well the real issue that it's form button when it doesn't need to be... We just want to do a GET without any form data then there wouldn't be a problem... We just need to work out how to do that.

@openstreetmap openstreetmap deleted a comment from scottrobel Jan 31, 2020
@openbrian
Copy link
Contributor

It should be pretty easy to style an anchor tag to look like a button.

@gravitystorm
Copy link
Collaborator

It should be pretty easy to style an anchor tag to look like a button.

Yes, we're moving to bootstrap for forms and buttons, and they have both buttons that look like links, and links that look like buttons, so we'll be sorted.

https://getbootstrap.com/docs/4.5/components/buttons/

@openbrian
Copy link
Contributor

I just happen to be using this which is working now. It's a blue button with white text. It looks pretty good.

<%= button_to t(".edit"), edit_thing_path(thing), :method => :get %>

It comes out like this

<form method=GET><input type=submit value="Edit"></form>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants