Multiple elements with non-unique id

[HolgerJeromin]

Chrome complains:

This DOM feels not right indeed:

[tomhughes]

This is useless unless you tell us what page you are referring to.

[HolgerJeromin]

As this is the main page www.openstreetmap.org with most subpages with map (way, node, relation) I forgot to mention :)

[tomhughes]

I think this is because there are two different versions of the form, one for the normal view and one for the mobile view, so it's probably not very easy to fix.

I suspect nothing actually uses the ids but rails probably generates them automatically - actual usage is probably via the form field names and hopefully always uses the form that is actually live and visible.

[mmd-osm]

This seems to be related to partial app/views/layouts/_search.html.erb being included twice in app/views/layouts/map.html.erb:

<% content_for :header do %>
  <%= render :partial => "layouts/search", :locals => { :autofocus => false } %>
<% end %>

<% content_for :content do %>
  <div id="sidebar">
    <%= render :partial => "layouts/search", :locals => { :autofocus => true } %>

Header level form was originally (re-)introduced in dd12e1d

[tomhughes]

Isn't that exactly what I said?

The first one is for the mobile site and the second one for the desktop site.

[mmd-osm]

Yes, you've already mentioned that. I thought it might be interesting to have a bit of context where this happens in the codebase.