Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outdated versions in INSTALL.md cause errors #2909

Closed
nlaratta opened this issue Oct 26, 2020 · 3 comments
Closed

Outdated versions in INSTALL.md cause errors #2909

nlaratta opened this issue Oct 26, 2020 · 3 comments

Comments

@nlaratta
Copy link
Contributor

nlaratta commented Oct 26, 2020

When following the instructions listed in INSTALL.md, which uses Ubuntu 18.04 and Ruby 2.5, we get these errors:

app/views/browse/note.html.erb:41: syntax error, unexpected ']'
app/views/browse/note.html.erb:41: syntax error, unexpected ']'
app/controllers/application_controller.rb:240:in 'web_timeout'
config/initializers/compressed_requests.rb:27:in 'call'
config/initializers/cors.rb:9:in 'call'

Further explanation from a team member: "All the errors I get are in relation to this app/views/browse/note.html.erb line 41 syntax error unexpected ']'. The brackets have a [1...] inside, if I edit the note.html.erb file so that the brackets on line 41 have [1..2] within them, the error goes away."

When following the instructions using Ubuntu 20.04 with Ruby 2.7, we get no errors. We asked in IRC-dev if this means that INSTALL.md might be due for an update, or if we messed up. We were told by a few people that Ubuntu 20.04 LTS is the version used by the OSMF Servers. This goes against what's stated in the document.

Is INSTALL.md due for an update?

@OmarBitar
Copy link

OmarBitar commented Oct 26, 2020

so I did an installation with Ubuntu 20.04 and ruby 2.5 and got the same errors from this old closed issue: #2212.
Localhost successfully renders the webpage and functions as expected, but I do get the errors mentioned earlier. I upgraded to 2.7, and I can confirm that I get no errors.

@mmd-osm
Copy link
Contributor

mmd-osm commented Oct 26, 2020

We were told by a few people that Ubuntu 20.04 LTS is the version used by the OSMF Servers. This goes against what's stated in the document.

That's right, INSTALL.md is outdated. Can you create a pull request?

Also, everyone, please don't post error messages as screenshots 🙄

@nlaratta
Copy link
Contributor Author

That's right, INSTALL.md is outdated. Can you create a pull request?

Also, everyone, please don't post error messages as screenshots 🙄

Sorry about the screenshots: I'll make a pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants