Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

possibility to attach photos to notes #395

Open
tyrasd opened this issue Jul 30, 2013 · 7 comments
Open

possibility to attach photos to notes #395

tyrasd opened this issue Jul 30, 2013 · 7 comments

Comments

@tyrasd
Copy link
Member

tyrasd commented Jul 30, 2013

Sometimes when adding a note it is not so easy to explain the actual map bug just with words alone (let's say you find a very complicated road sign and don't really know what's going on). In that case it would be helpful for both the note submitter and the mappers if photos of the location could be attached to the note.

@matkoniecz
Copy link
Contributor

StreetComplete has support for attaching photos using third-party service. In my experience this feature is extremely useful.

The trouble with using third-party services is that each note-generating client needs to implement it on each own and it is fragile (StreetComplete was recently affected by photo-storage discontinued).

Is it viable to store photos directly on OSM servers? It would be nice to know is there some fundamental blocker before somebody starts implementing this feature.

@westnordost
Copy link

In other words, would you accept a PR if someone was to implement it?

@tomhughes
Copy link
Member

Only if OWG were prepared to provide significant server resources to support the service.

@matkoniecz
Copy link
Contributor

And answer in openstreetmap/operations#206 is

My initial reaction is: not in the short term. We have been planning to move the website storage (e.g. user images, gpx files) off of a centralised machine and onto a storage cluster, but that is still in progress.

@1ec5
Copy link
Contributor

1ec5 commented Aug 5, 2018

Photos could provide useful context in a note, but allowing images in notes could also increase the potential for abuse. Inappropriate images including copyright infringement could become more common. We allow profile photos, but those are small compared to what I’d imagine we’d want to enable within notes.

@dankarran
Copy link
Contributor

This would be a handy feature, though as others have noted it's potentially open for misuse.

From a quick read through openstreetmap/operations#206 and openstreetmap/operations#169 it looks like S3 may now be in place as an object store - does that mean the storage blocker for this has gone?

@gravitystorm
Copy link
Collaborator

Yes, there's two technical aspects that have changed since these related tickets were opened. The first is that OSMF is using an object store for hosting files (e.g. user avatars and gpx traces), currently AWS S3, and secondly Rails has the ActiveStorage feature which takes care of the uploading / downloading / image resizing etc and makes it much easier (less code) to add this kind of functionality.

The policy topics - e.g. inappropriate image hosting, moderation etc - are unaffected and there hasn't been any recent discussions on this topic as far as I'm aware.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants