Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename "Resolved note" to "Closed note" #4139

Open
Dimitar5555 opened this issue Aug 7, 2023 · 2 comments
Open

Rename "Resolved note" to "Closed note" #4139

Dimitar5555 opened this issue Aug 7, 2023 · 2 comments

Comments

@Dimitar5555
Copy link
Contributor

Problem

It seems like new mappers think that pressing the "Resolve" button on a note automagically resolves the note which is not the case unfortunately.

Description

I think that "Close" should be a lot more clearer given that notes are divided into open and closed. Some other strings would also need to change (Resolved Note -> Closed Note, Comment and resolve -> Comment and close).

Screenshots

No response

@AntonKhorev
Copy link
Contributor

In some locales it's already labeled as "close".

@dankarran
Copy link
Contributor

If the user isn't really paying attention, they may click 'Close' to simply hide the note panel though. Perhaps it could be named a bit more explicitly as something like 'Mark as closed' or 'Mark as resolved'?

Related, might it make sense to require a comment of some sort before closing the note?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants