Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding "print" button #430

Closed
pointhi opened this issue Aug 7, 2013 · 9 comments
Closed

adding "print" button #430

pointhi opened this issue Aug 7, 2013 · 9 comments

Comments

@pointhi
Copy link

pointhi commented Aug 7, 2013

I find it is important to add a function to print the current map-view. Due to the different dimensions of screen, the print result isn't equal to the screen, and important pois on the side wouldn't be displayed.

The page-preview function in firefox and co. isn't a easy methode to become the sheet who you want, a special function like google and co is in my eyes necessary.

@tomhughes
Copy link
Member

As far as I can see all the google button does is open the map in a new window with much of the chrome removed, and we have a print stylesheet that does that automatically when you print.

I've never known a browser do what you seem to be suggesting, and print something other than what is displayed - they fit the screen to the paper normally. What browser are you using that is not doing that?

@pointhi
Copy link
Author

pointhi commented Aug 7, 2013

i use firefox, and it use the print stylesheet to remove unnecessary things, but it cut of the edges (left and bottom). with a new window or so you can see what would be cutted away and can move/resize the map to displayed it correctly on A4 or an other format.

EDIT:

I have install a alternated OSM-Style with greasmonkey (bigger map), but when i deactivated it, the print preview show me also a smaller pice of the map on the paper, as on the screen.

@sabas
Copy link

sabas commented Aug 8, 2013

I noted that page printing defaults to portrait mode and takes only the very left part of the map view.
What about defaulting to something like this?

@media print{@page {size: landscape}}

@pointhi
Copy link
Author

pointhi commented Aug 9, 2013

i think that can made a better result. I doesn't know about other people, but I'm make my maps only in horizontal format. what is with editing it to:?

@media print{@page {size: auto}}

Can this work?, or can you define different css-markups for vertical and horizontal format? I know that this doesn't solve the problem completely. Nobody know how much of the right and or bottom edge would be cut down before going in print-preview, but it can produce better results as without editing the css.

I have made a picture to show, how much of the map would be cutted down by printing (horizontal size)
Print vs Screen-Size

@tomhughes
Copy link
Member

Well size: auto is the default and won't help at all - that tells it to use the size of the target sheet which will then depend on whether you have portrait or landscape set in your print options.

We could set size: landscape and that will likely improve things if we think that the majority of users will be using a browser window that is wider than it is tall.

@pointhi
Copy link
Author

pointhi commented Aug 9, 2013

What I have found out is, that size is only supported on Opera. So, size isn't the solution for this problem.

@sabas
Copy link

sabas commented Aug 9, 2013

Actually I used size:portrait on chrome... (and OT Opera as rendering engine is no more )

@pointhi
Copy link
Author

pointhi commented Aug 13, 2013

an other idea: I have resize the map on the print-layout-dialoge to 70%, and now, the map wouldn't cutted so much. But this isn't a fix value, because it is depending from the screen size. The advantages are, that an implementation would work on more browsers.

@gravitystorm
Copy link
Collaborator

I appreciate that printing the maps is something that a number of people want to do, but it's not a priority for our small team of developers to work on this. So I'm going to close this feature request.

If anyone wants to make changes to the printing functionality, particularly if there's changes to the existing print.css stylesheet, then we welcome such pull requests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants