Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add profile pictures to object (nwr), history and changeset views #4403

Open
dieterdreist opened this issue Dec 13, 2023 · 3 comments
Open

Comments

@dieterdreist
Copy link

Problem

Add markup for a mini-profile-icon before the username in changeset, history and browse-{nwr} views

Description

this is a suggestion

Screenshots

mini-profile-pics

@AntonKhorev
Copy link
Contributor

Isn't is too small? The smallest avatar size in use right now is 25x25px. But if you make it larger here, it would look odd as an inline element. So maybe it's better to start with an image. Instead of "Closed over 12 years ago by [image] username" have "[image] username closed over 12 years ago"?

On the other hand maybe there are no avatars on osm data elements to avoid promoting the idea that users "own" them - something that is not done with diary posts for example.

@dieterdreist
Copy link
Author

You are right that it is quite small, if a bigger image is preferred it does not work well at this inline position. Your suggestion to change the order is good, in alternative the mapper could be named in a new line (similar solution).

While you don't "own" the elements, you certainly are responsible for (or "own" it if you like) the changeset / edits you uploaded.

@AntonKhorev
Copy link
Contributor

Another reason not to have avatars on elements is long history pages. Some elements have 100+ versions. Their history pages are already slow to load. If you add images, that will make things even slower.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants