Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Order of comments in changeset comments feeds #4613

Open
AntonKhorev opened this issue Mar 22, 2024 · 1 comment
Open

Order of comments in changeset comments feeds #4613

AntonKhorev opened this issue Mar 22, 2024 · 1 comment

Comments

@AntonKhorev
Copy link
Contributor

Problem

Does it make sense for comments in a feed to go in ascending order, oldest first?

Comment feeds for all comments are sorted in descending order:
https://master.apis.dev.openstreetmap.org/history/comments/feed

But feeds for individual changesets are sorted in ascending order:
https://master.apis.dev.openstreetmap.org/changeset/307182/comments/feed

If you add a limit, and there's more comments than the limit, you'll never get new comments:
https://master.apis.dev.openstreetmap.org/changeset/307182/comments/feed?limit=1

Description

No response

Screenshots

No response

@milan-cvetkovic
Copy link
Contributor

We probably want descending order, with newest comments being fist on the list.

I think it would also be useful to order them by id instead of created_at, since in theory ordering by timestamp and id does not have to match.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants