Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the text of a mail about comments to a changeset #4806

Closed
deevroman opened this issue May 17, 2024 · 11 comments
Closed

Improve the text of a mail about comments to a changeset #4806

deevroman opened this issue May 17, 2024 · 11 comments

Comments

@deevroman
Copy link

deevroman commented May 17, 2024

Problem

Inspired by comment in the community chat:

It took me 2 months and a block before I found how to reply. I see the comments on the mail, I take note, but how to reply is unclear.

Снимок экрана 2024-05-17 в 10 35 11

What if the text "More details about the changeset can be found at %{url}." is replaced with: "Reply or learn more about the changeset at %{url}"?

Description

No response

Screenshots

No response

@HolgerJeromin
Copy link
Contributor

The text is defined here:

details: "More details about the changeset can be found at %{url}."

@AntonKhorev
Copy link
Contributor

Currently it's similar to note notifications that also don't say how to reply.

@kleenkanteen
Copy link
Contributor

kleenkanteen commented May 18, 2024

@HolgerJeromin

1.How does one test sending an email locally?

  1. Also is there a script that allows one make edits to a text, say for this sentence for example, in all languages using a translation API? I could make the change in english but there are tens of other languages supported. If it doesn't exist, would it be a good idea to implement?

  2. Why is the text duplicated on lines 1692-1693 in the file you quoted?:

details: "More details about the changeset can be found at %{url}."
details_html: "More details about the changeset can be found at %{url}."

@AntonKhorev
Copy link
Contributor

Why is the text duplicated on lines 1692-1693 in the file you quoted?

Emails contain both html and plaintext.

@AntonKhorev
Copy link
Contributor

How does one test sending an email locally?

If you want to test the mailer output, see for example https://github.com/openstreetmap/openstreetmap-website/blob/master/test/mailers/user_mailer_test.rb

@AntonKhorev
Copy link
Contributor

Also is there a script that allows one make edits to a text, say for this sentence for example, in all languages using a translation API?

https://github.com/openstreetmap/openstreetmap-website/blob/master/CONTRIBUTING.md#i18n

@sjvudp
Copy link

sjvudp commented May 18, 2024

Sorry, if this is not exactly on-topic, but:
I frequently get messages about responses to an OSM note (hint). As it lacks the original note, I can only guess from the mail message what it might refer to. To find out, I'll have to follow the link.
Working on a desktop, but reading mail on the mobile (while on the road), I cannot easily reply to the comments I still would have to log in to OSM from the mobile phone (but I don't have the credentials there, because I use a random passwords only my password manager on the desktop can remember.
So it would be nice if the link in the mail message had some magic access token embedded that does not require login, just to respond to a comment.
In general I think having a "worklist" with all the comments that were sent by mail when being logged in to OSM would be very helpful. Switching between the E-Mail browser tab and the OSM browser tab to work on the messages one-by-one is not very efficient (and it is little fun).

@kleenkanteen
Copy link
Contributor

@sjvudp Are you asking for these 3 things?:

  1. Having the original note as well as the reply in the email.
  2. Having a magic access token when clicking on the the email's view changeset link.
  3. A easier way to reply to comments on OSM (I am not sure what you mean by this exactly).

Feel free to clarify any

@sjvudp
Copy link

sjvudp commented May 18, 2024

#1 and #2 are correct.
#3 is when you have something like 30 comments on 25 different notes, and you want to review them all (independently from the email messages received). I agree that this item is not directly related to sending out mail messages. Instead it's about an efficient workflow.

@tordans
Copy link
Contributor

tordans commented May 19, 2024

Ping also to #4047 which would improve the situation with very little change IMO.

@tomhughes
Copy link
Member

Fixed in #4812.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants