Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow markdown in changeset comments #844

Open
fuddl opened this issue Nov 24, 2014 · 14 comments
Open

allow markdown in changeset comments #844

fuddl opened this issue Nov 24, 2014 · 14 comments

Comments

@fuddl
Copy link

fuddl commented Nov 24, 2014

would be nice to link to something like another edit or a wiki page. or posting pictures

@tomhughes
Copy link
Member

There really isn't enough space in the UI to have pictures there, which is the reason we don't Markdown. If links aren't working then I would consider that a bug - have you actually tried it?

@fuddl
Copy link
Author

fuddl commented Nov 24, 2014

Yes I did

I don't see the problem since images could be simply shrinked like in the user's diaries:

.richtext img, .prose img {
  padding: 20px;
  background-color: #f4f4ff;
  display: block;
  max-width: 100%;
  margin: auto;
}

p>img {
  width: auto;
  max-width: 100%;
}

@tomhughes
Copy link
Member

Right so links do work, just don't try and use Markdown syntax for them because we don't do Markdown in comments ;-)

Obviously we can shrink images, but they would wind up ridiculously small!

@fuddl
Copy link
Author

fuddl commented Nov 24, 2014

while links (without link text) become ridiculously long 😜

link is too long

@fuddl
Copy link
Author

fuddl commented Nov 24, 2014

so anyway I suggest supporting markdown because it can be used everywhere on osm.org and its a useful thing

@tomhughes
Copy link
Member

Not quite true - we don't allow it in notes either, for the same reason ;-)

@fuddl
Copy link
Author

fuddl commented Nov 24, 2014

okay, I'll file that as a separate issue. 😉

so I suppose this should be closed…

@fuddl fuddl closed this as completed Nov 24, 2014
@tomhughes tomhughes reopened this Nov 24, 2014
@tomhughes
Copy link
Member

Why did you feel the need to close this? It's a valid request though as I say there are problems that need to be considered.

Please don't open the same issue for notes - there already is one I belive.

@tomhughes
Copy link
Member

#693 covers notes.

@fuddl
Copy link
Author

fuddl commented Nov 24, 2014

Please don't open the same issue for notes - there already is one I belive.

I was joking

@fuddl
Copy link
Author

fuddl commented Nov 24, 2014

Made a quick mockup.

this is what it looks on mobile:
mobile

this is what it looks on desktop:
desktop

@fuddl
Copy link
Author

fuddl commented Dec 9, 2014

@tomhughes do you think images would be ridiculously small?

@planemad
Copy link

Would love to see this. Having images (even thumbnails) adds great context to conversation and makes the thread more readable.

@pnorman
Copy link
Contributor

pnorman commented Jul 30, 2016

Do we do Markdown on anything API accessible?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants