Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification of changeset comment should generate a OSM message, not a normal mail #908

Closed
simonpoole opened this issue Feb 24, 2015 · 12 comments

Comments

@simonpoole
Copy link
Contributor

Currently creating a changeset comment generates a notice to the changeset creator directly via e-mail, unluckily such automated mails are prone to getting lost and depend on the destination e-mail still working in the first place. As we know from the licence change the later is not given at all.

It would be better to generate an internal message (which would trigger a mail notification to the user anyway) . If the notification is missed you still have the message count on the website and notifications in the editors to point out that you may need to act.

Further: in the current scenario "zero hour" blocks do not really work without the DWG sending a message to the user pointing out that he hasn't responded to a changeset comment.

No patch for now as the subject is likely a bit controversial.

@SomeoneElseOSM
Copy link

(and something else in the same area) it would be nice if you could reply to changeset discussion comment emails the same way that you can to OSM message emails. Would this also follow from Simon's suggestion above?

@simonpoole
Copy link
Contributor Author

Likely no, you would be replying to the noticiation message, which is not the the same as the changeset discussion itself.

@tomhughes
Copy link
Member

Whilst it would be possible to have a new code in the reply address that marked it as a changeset comment that should be appended to the changeset discussion I would prefer not to do that for aesthetic reasons.

The problem is that emailed comments always wind up looking rather awkward/ugly and whilst it's one thing to accept that in the private context of messages I'd rather not encourage that in a public facing context like changeset comments.

@pnorman
Copy link
Contributor

pnorman commented Feb 24, 2015

I would like it to be easier for a user to see if there are comments on their changesets and to get notification through the website that they have had a discussion on one of their changesets. I'd also like to be able to see what changesets a different user has done that have had discussions.

I don't see that user messages would particularly solve the problem of users If they are not getting changeset discussion emails they probably won't get message emails either as they come from the same source.

There is no need for sending a private message to go along with zero hour block as the block itself can contain a message to the user directing them to the discussion they need to be involved in.

@neiljp
Copy link

neiljp commented Feb 24, 2015

Could this be incorporated into a list of active/involved discussions, like how each user has a list of the notes they're involved with on their profile?

@simonpoole
Copy link
Contributor Author

@neiljp It is true that right now the notification mails are the only means to find out which discussions you've participated in and that is why them getting lost in e-mail nirvana is such a pain, but actually having a list is a different topic and I believe there is already an open issue wrt that.

@polarbearing
Copy link
Contributor

actually having a list is a different topic and I believe there is already an open issue wrt that.

Yes: #842

@biswesh456
Copy link
Contributor

Hello, I was looking at the ideas list and came across this. Can I take this as a GSOC project. Can someone guide me if this is a project good enough for GSOC. Also since no mentors have been mentioned can I be referred to someone who can guide me for this project?

Thanks

@simonpoole
Copy link
Contributor Author

simonpoole commented Mar 7, 2018

@biswesh456 As part as a larger project to improve the messaging infrastructure on osm.org yes, stand-alone far too thin.

@biswesh456
Copy link
Contributor

@simonpoole Can I be guided on any specific things that are wanted in the messaging infrastructure of osm.org? I would love to contribute to it.

Thanks

@simonpoole
Copy link
Contributor Author

#1387
#1431
and the proposed group functionality for starters.

@gravitystorm
Copy link
Collaborator

The topic of notifications is a broad one, and one that we could definitely improve on. I would like in the future to have a system where all the various activities (commenting on changesets, receiving a message, whatever) create a notification, and users can control how they want to receive notifications (email, instant messaging, only on the website, etc). At the moment users have no control over notifications (only via email) and there's no way to review all the notifications that you've received retrospectively.

But this specific request is for an activity to trigger the creation of a message. I don't think that's a good approach, since it dilutes the concept of a message, and it would make it harder in the long run to create a proper notification system. So I'm closing this issue in favour of #1387

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants