Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

append new ScheduleRule objects rather than inserting to top #326

Closed
MatthewSteen opened this issue Mar 24, 2021 · 2 comments
Closed

append new ScheduleRule objects rather than inserting to top #326

MatthewSteen opened this issue Mar 24, 2021 · 2 comments
Labels
OpenStudio SDK Issue An issue that is not related to OpenStudioApplication but to NREL/OpenStudio SDK

Comments

@MatthewSteen
Copy link

Enhancement Request

See #127 (comment). Minor annoyance when adding ScheduleRules sequentially from the beginning of the year to the end.

Detailed Description

This is what happens to the first Run Period Profile after adding another one.

image

Possible Implementation

Change how Rule Order is set.
@MatthewSteen MatthewSteen added Enhancement Request New feature or request Triage Issue needs to be assessed and labeled, further information on reported might be needed labels Mar 24, 2021
@macumber
Copy link
Collaborator

macumber commented May 28, 2021 •
edited by jmarrec

I think this is an OpenStudio SDK issue, ScheduleRule's put themselves at index 0 on creation

https://github.com/NREL/OpenStudio/blob/92a416c03a98b44b67668e5b3d6d3c89be729afa/src/model/ScheduleRule.cpp#L596

@macumber macumber added OpenStudio SDK Issue An issue that is not related to OpenStudioApplication but to NREL/OpenStudio SDK and removed Enhancement Request New feature or request Triage Issue needs to be assessed and labeled, further information on reported might be needed labels May 28, 2021
@jmarrec
Copy link
Collaborator

jmarrec commented May 31, 2021

Closing, it's an SDK thing. Feel free to open an issue over there.

@jmarrec jmarrec closed this as completed May 31, 2021
@MatthewSteen MatthewSteen mentioned this issue Jun 1, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
OpenStudio SDK Issue An issue that is not related to OpenStudioApplication but to NREL/OpenStudio SDK
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@macumber @jmarrec @MatthewSteen