Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geometry preview - search feature #404

Closed
antoine-galataud opened this issue Jul 22, 2021 · 5 comments · Fixed by #405
Closed

Geometry preview - search feature #404

antoine-galataud opened this issue Jul 22, 2021 · 5 comments · Fixed by #405
Labels
Enhancement Request New feature or request

Comments

@antoine-galataud
Copy link
Contributor

Enhancement Request

Use case: an EnergyPlus simulation is run and there are some errors / warnings about surfaces / thermal zones in eplusout.err. It can be useful to quickly show the concerned objects in geometry preview.

This is more relevant for larger buildings or when no naming convention was applied (ie Surface 202, Surface 203 ...), as it'll often imply long look up times.

@antoine-galataud antoine-galataud added Enhancement Request New feature or request Triage Issue needs to be assessed and labeled, further information on reported might be needed labels Jul 22, 2021
@macumber macumber removed the Triage Issue needs to be assessed and labeled, further information on reported might be needed label Jul 29, 2021
@macumber
Copy link
Collaborator

This looks cool @antoine-galataud, thanks!

I'd also like to apply this as a PR to https://github.com/NREL/openstudio-common-measures-gem/tree/develop/lib/measures/view_data and https://github.com/NREL/openstudio-common-measures-gem/tree/develop/lib/measures/view_model and will tag you on that (unless you want to make the pr yourself?)

@macumber
Copy link
Collaborator

I might also try to make the search function search according to the current render mode and also to highlight all matching surfaces.

@antoine-galataud
Copy link
Contributor Author

@macumber thanks!

I might also try to make the search function search according to the current render mode

Not sure how well it will render? From a user experience perspective I found keeping only wireframe displayed is visually appealing.

also to highlight all matching surfaces

Totally makes sense. Please see my latest commit and below example of implementation

Screenshot from 2021-07-29 10-52-38

Note: displayed information about matching results will be limited to 2 objects, to avoid overflow in main frame.

@antoine-galataud
Copy link
Contributor Author

@macumber just re-read your last comment and realized I misunderstood. Did you mean searching only among objects having type equal to current render mode? Would make sense indeed

@antoine-galataud
Copy link
Contributor Author

@macumber I implemented search according to current render mode, so it will search only among objects that match render by type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Request New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants