Update originalReleaseDate field to new ItemDate type #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for opensubsonic ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
CC @certuna |
|
The year needs to be optional too. If the server support the field it must return it not null, so in this case an empty object without year or month or day. |
Tolriq
approved these changes
Dec 22, 2023
epoupon
approved these changes
Dec 22, 2023
deluan
approved these changes
Dec 23, 2023
deluan
added a commit
to navidrome/navidrome
that referenced
this pull request
Dec 23, 2023
deluan
added a commit
to navidrome/navidrome
that referenced
this pull request
Dec 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: this is a breaking change but as of now, LMS (server) and Symfonium (client) are the only users of this field, and they have coordinated the ability to make the change.
This is needed because the original type of the field was an ISO date which does not allow the representation of "partial" dates (ie only year known, or year and month), which is a common scenario with music file tags.