Skip to content

Commit

Permalink
chore: improve code
Browse files Browse the repository at this point in the history
  • Loading branch information
Ricbet committed May 24, 2024
1 parent 3c0e884 commit 36fab2c
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 37 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -20,14 +20,6 @@ export class CodeActionHandler extends Disposable {
@Autowired(LanguageParserService)
private readonly languageParserService: LanguageParserService;

private shouldAbortRequest(model: monaco.ITextModel) {
if (model.uri.scheme !== Schemes.file) {
return true;
}

return false;
}

public registerCodeActionFeature(languageId: string, editor: IEditor): IDisposable {
const disposable = new Disposable();

Expand All @@ -41,7 +33,7 @@ export class CodeActionHandler extends Disposable {
}

const { monacoEditor } = editor;
const { languageParserService, inlineChatFeatureRegistry, shouldAbortRequest } = this;
const { languageParserService, inlineChatFeatureRegistry } = this;

let codeActionDispose: IDisposable | undefined;

Expand Down Expand Up @@ -74,10 +66,6 @@ export class CodeActionHandler extends Disposable {

codeActionDispose = languageFeaturesService.codeActionProvider.register(languageId, {
provideCodeActions: async (model) => {
if (shouldAbortRequest(model)) {
return;
}

if (!prefInlineChatActionEnabled) {
return;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,14 +23,6 @@ export class InlineCompletionHandler extends Disposable {
@Autowired(AICompletionsService)
private aiCompletionsService: AICompletionsService;

private shouldAbortRequest(model: monaco.ITextModel) {
if (model.uri.scheme !== Schemes.file) {
return true;
}

return false;
}

public registerInlineCompletionFeature(editor: IEditor): IDisposable {
const { monacoEditor } = editor;
// 判断用户是否选择了一块区域或者移动光标 取消掉请补全求
Expand Down Expand Up @@ -97,10 +89,6 @@ export class InlineCompletionHandler extends Disposable {
disposable.addDispose(
monacoApi.languages.registerInlineCompletionsProvider(languageId, {
provideInlineCompletions: async (model, position, context, token) => {
if (this.shouldAbortRequest(model)) {
return;
}

if (middlewareCollector?.language?.provideInlineCompletions) {
this.aiCompletionsService.setMiddlewareComplete(middlewareCollector?.language?.provideInlineCompletions);
}
Expand Down
12 changes: 0 additions & 12 deletions packages/ai-native/src/browser/contrib/rename/rename.handler.ts
Original file line number Diff line number Diff line change
Expand Up @@ -21,22 +21,10 @@ export class RenameHandler extends Disposable {
private lastModelRequestRenameEndTime: number | undefined;
private lastModelRequestRenameSessionId: string | undefined;

private shouldAbortRequest(model: monaco.ITextModel) {
if (model.uri.scheme !== Schemes.file) {
return true;
}

return false;
}

public registerRenameFeature(languageId: string): IDisposable {
const disposable = new Disposable();

const provider = async (model: monaco.ITextModel, range: monaco.IRange, token: CancellationToken) => {
if (this.shouldAbortRequest(model)) {
return;
}

this.lastModelRequestRenameSessionId = undefined;

const startTime = +new Date();
Expand Down

0 comments on commit 36fab2c

Please sign in to comment.