Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] remove shortid dependency #882

Closed
bytemain opened this issue Apr 20, 2022 · 6 comments · Fixed by #923
Closed

[FEATURE] remove shortid dependency #882

bytemain opened this issue Apr 20, 2022 · 6 comments · Fixed by #923
Labels
🎨 feature feature required 👨🏻‍💻 good first issue Good for newcomers 🤔 help wanted Extra attention is needed
Milestone
2.18

Comments

@bytemain
Copy link
Member

虽说我们对创建 uuid 的性能要求不高，但是市面上有更好，更快速的 uuid 生成器，可以考虑换掉 shortid 这个依赖

需要等待 refactor: add @opensumi/ide-utils module 完成后再做。
@bytemain bytemain added the 🎨 feature feature required label Apr 20, 2022
@bytemain bytemain added this to the 2.18 milestone Apr 20, 2022
@bytemain bytemain added 🤔 help wanted Extra attention is needed 👨🏻‍💻 good first issue Good for newcomers labels Apr 22, 2022
@dqhl76
Copy link
Contributor

dqhl76 commented Apr 22, 2022

我可以试着做这个吗？

@bytemain
Copy link
Member Author

这个需要等 #784 好了再做，目前还不能开始

@dqhl76
Copy link
Contributor

dqhl76 commented Apr 22, 2022

好的，我先看一看相关的代码

@bytemain
Copy link
Member Author

npm 生态一些库的 benchmark：

@erha19
Copy link
Member

erha19 commented Apr 26, 2022

@dqhl76 这块内容可以搞了， 2.17 已发布

@dqhl76
Copy link
Contributor

dqhl76 commented Apr 26, 2022

好的

@dqhl76 dqhl76 mentioned this issue Apr 27, 2022
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🎨 feature feature required 👨🏻‍💻 good first issue Good for newcomers 🤔 help wanted Extra attention is needed
Projects
None yet
Milestone
2.18
Development

Successfully merging a pull request may close this issue.

feat: remove shortid dependency
3 participants
@erha19 @bytemain @dqhl76