-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: remove shortid dependency #923
Conversation
Codecov Report
@@ Coverage Diff @@
## main #923 +/- ##
=======================================
Coverage 58.48% 58.48%
=======================================
Files 1220 1220
Lines 75099 75099
Branches 15616 15616
=======================================
+ Hits 43923 43924 +1
+ Misses 28416 28415 -1
Partials 2760 2760
Continue to review full report at Codecov.
|
@bytemain 请问刚才是重新运行了一下CI,它就不报错了吗 |
需要解决一下冲突: 首先把 opensumi/core:main 设置为你的上游。 git remote add upstream https://github.com/opensumi/core.git
git pull upstream main --rebase 然后就可以解决冲突了 |
好的,我已经解决了冲突,感谢您的指导,剩下我需要做的是:
|
CI/coverage(12.x)这个似乎又是和我本次PR无关的问题失败了,我在我fork的仓库中跑了一下是没问题的,但我没有办法让它重新在这个仓库重新运行, @erha19 @bytemain 可以帮我重新跑一下这个CI吗 |
Types
Background or solution
Use nanoid to replace shortid
close #882
Changelog
replace shortid with nanoid dependency