Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: the min-width property name of the toolbar button #152

Merged
merged 1 commit into from
Dec 20, 2021

Conversation

yantze
Copy link
Member

@yantze yantze commented Dec 20, 2021

变动类型

  • 日常 bug 修复

需求背景和解决方案

使用 toolbar 的 button 会报下面的错误:
image

changelog

  • 修复 Toolbar 按钮的 min-width 属性名

@codecov-commenter
Copy link

Codecov Report

Merging #152 (3ed0001) into main (ccd89f1) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #152      +/-   ##
==========================================
- Coverage   59.41%   59.40%   -0.01%     
==========================================
  Files        1180     1180              
  Lines       72334    72334              
  Branches    14972    14972              
==========================================
- Hits        42979    42973       -6     
- Misses      26753    26758       +5     
- Partials     2602     2603       +1     
Impacted Files Coverage Δ
packages/core-common/src/node/port.ts 43.93% <0.00%> (-3.04%) ⬇️
packages/monaco/src/browser/schema-registry.ts 68.88% <0.00%> (-2.23%) ⬇️
...erences/src/browser/preference-settings.service.ts 79.16% <0.00%> (-0.70%) ⬇️
...kages/theme/src/browser/workbench.theme.service.ts 71.77% <0.00%> (-0.61%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ccd89f1...3ed0001. Read the comment docs.

Copy link
Member

@erha19 erha19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants