Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement InputBoxValidationMessage and InputBoxValidationSeverity #1593

Merged
merged 1 commit into from
Sep 14, 2022

Conversation

hacke2
Copy link
Member

@hacke2 hacke2 commented Aug 29, 2022

Types

  • 🎉 New Features

Background or solution

resolve #1409

warning

image

error

image

Changelog

implement InputBoxValidationMessage and InputBoxValidationSeverity

@codecov
Copy link

codecov bot commented Aug 29, 2022

Codecov Report

Base: 57.69% // Head: 57.76% // Increases project coverage by +0.07% 🎉

Coverage data is based on head (db7329b) compared to base (236fd4c).
Patch coverage: 54.71% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1593      +/-   ##
==========================================
+ Coverage   57.69%   57.76%   +0.07%     
==========================================
  Files        1254     1254              
  Lines       78139    78180      +41     
  Branches    16328    16350      +22     
==========================================
+ Hits        45079    45159      +80     
+ Misses      30091    30054      -37     
+ Partials     2969     2967       -2     
Flag Coverage Δ
jsdom 52.56% <54.71%> (+0.07%) ⬆️
node 15.84% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/core-browser/src/quick-open/index.ts 77.63% <ø> (ø)
.../src/hosted/api/vscode/ext.host.window.api.impl.ts 14.61% <0.00%> (ø)
...ages/quick-open/src/browser/quickInput.inputBox.ts 33.01% <0.00%> (+1.59%) ⬆️
...ages/quick-open/src/browser/quick-input-service.ts 65.11% <33.33%> (-2.39%) ⬇️
...on/src/browser/vscode/api/main.thread.quickopen.ts 54.11% <45.83%> (+11.93%) ⬆️
...ension/src/hosted/api/vscode/ext.host.quickopen.ts 35.55% <61.53%> (+15.10%) ⬆️
packages/extension/src/common/vscode/enums.ts 100.00% <100.00%> (ø)
packages/extension/src/common/vscode/ext-types.ts 50.54% <100.00%> (+0.14%) ⬆️
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@hacke2
Copy link
Member Author

hacke2 commented Aug 29, 2022

测试插件写法

vscode.window.showInputBox({
    ignoreFocusOut: true,
    validateInput: (text) => {
      return  {
        message: text,
        severity: vscode.InputBoxValidationSeverity.Error
      }
    }
});

@hacke2 hacke2 force-pushed the feat/InputBoxValidationMessage branch from c7aa6b7 to db7329b Compare September 7, 2022 07:10
Copy link
Member

@Ricbet Ricbet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@erha19 erha19 merged commit f1caaec into main Sep 14, 2022
@erha19 erha19 deleted the feat/InputBoxValidationMessage branch September 14, 2022 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] InputBoxValidationMessage
3 participants