Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement quickpick kind api #1673

Merged
merged 1 commit into from
Sep 27, 2022
Merged

feat: implement quickpick kind api #1673

merged 1 commit into from
Sep 27, 2022

Conversation

hacke2
Copy link
Member

@hacke2 hacke2 commented Sep 19, 2022

Types

  • 🎉 New Features

Background or solution

image

const items = [
		{
			label: 'APIs',
			kind: vscode.QuickPickItemKind.Separator
		},
		{
			label: 'showQuickPick',
		},
		{
			label: 'showInputBox',
		},
		{
			label: 'createQuickPick',
		},
		{
			label: 'createInputBox',
		},
		{
			label: 'Types',
			kind: vscode.QuickPickItemKind.Separator
		},
		{
			label: 'QuickPickItemKind',
		},
		{
			label: 'QuickInputButton',
		},
		{
			label: 'QuickQuick',
		},
		{
			label: 'InputBox',
		},
	];
 const result = await vscode.window.showQuickPick(items);
vscode.window.showInformationMessage(`You selected: ${result?.label ?? 'nothing'}`);

Changelog

implement quickpick kind api

@hacke2
Copy link
Member Author

hacke2 commented Sep 19, 2022

resolve #1667

@Ricbet Ricbet linked an issue Sep 20, 2022 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Sep 22, 2022

Codecov Report

Base: 57.68% // Head: 57.69% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (f965afe) compared to base (ecb4569).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1673   +/-   ##
=======================================
  Coverage   57.68%   57.69%           
=======================================
  Files        1269     1269           
  Lines       78979    78988    +9     
  Branches    16528    16532    +4     
=======================================
+ Hits        45559    45570   +11     
+ Misses      30405    30403    -2     
  Partials     3015     3015           
Flag Coverage Δ
jsdom 52.53% <100.00%> (+<0.01%) ⬆️
node 15.79% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/extension/src/common/vscode/ext-types.ts 50.65% <100.00%> (+0.10%) ⬆️
...ension/src/hosted/api/vscode/ext.host.quickopen.ts 37.69% <100.00%> (+2.13%) ⬆️
...erences/src/browser/preference-settings.service.ts 75.00% <0.00%> (-0.63%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@erha19 erha19 merged commit a396ed0 into main Sep 27, 2022
@erha19 erha19 deleted the feat/quickpick-kind branch September 27, 2022 09:31
yantze pushed a commit that referenced this pull request Sep 29, 2022
# Conflicts:
#	packages/extension/__tests__/hosted/api/vscode/ext.host.quickopen.test.ts
yantze pushed a commit that referenced this pull request Oct 10, 2022
# Conflicts:
#	packages/extension/__tests__/hosted/api/vscode/ext.host.quickopen.test.ts
@erha19 erha19 mentioned this pull request Oct 12, 2022
55 tasks
@hacke2
Copy link
Member Author

hacke2 commented Jan 12, 2023

fix #1245

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] 2.19.11 选择 TS 版本功能失效
2 participants