Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revealInSideBar invalid #1682

Merged
merged 1 commit into from
Sep 20, 2022
Merged

fix: revealInSideBar invalid #1682

merged 1 commit into from
Sep 20, 2022

Conversation

Ricbet
Copy link
Member

@Ricbet Ricbet commented Sep 20, 2022

Types

  • 🐛 Bug Fixes

Background or solution

Changelog

修复 SCM 的"在侧边栏打开"失效的问题

@Ricbet Ricbet linked an issue Sep 20, 2022 that may be closed by this pull request
@Ricbet Ricbet self-assigned this Sep 20, 2022
Copy link
Member

@hacke2 hacke2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@codecov
Copy link

codecov bot commented Sep 20, 2022

Codecov Report

Base: 57.64% // Head: 57.68% // Increases project coverage by +0.04% 🎉

Coverage data is based on head (94e812e) compared to base (795a5b4).
Patch coverage: 63.44% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1682      +/-   ##
==========================================
+ Coverage   57.64%   57.68%   +0.04%     
==========================================
  Files        1256     1269      +13     
  Lines       78425    78950     +525     
  Branches    16439    16516      +77     
==========================================
+ Hits        45206    45541     +335     
- Misses      30222    30395     +173     
- Partials     2997     3014      +17     
Flag Coverage Δ
jsdom 52.51% <61.17%> (+0.05%) ⬆️
node 15.80% <13.63%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/collaboration/src/browser/index.ts 0.00% <0.00%> (ø)
packages/collaboration/src/node/index.ts 0.00% <0.00%> (ø)
packages/editor/src/browser/preference/schema.ts 100.00% <ø> (ø)
packages/i18n/src/common/en-US.lang.ts 100.00% <ø> (ø)
packages/i18n/src/common/zh-CN.lang.ts 100.00% <ø> (ø)
...ackages/collaboration/src/browser/cursor-widget.ts 12.69% <12.69%> (ø)
packages/editor/src/browser/history/index.ts 65.71% <14.28%> (-18.04%) ⬇️
...collaboration/src/browser/collaboration.service.ts 74.35% <74.35%> (ø)
...kages/collaboration/src/node/y-websocket-server.ts 76.19% <76.19%> (ø)
...ges/collaboration/src/browser/textmodel-binding.ts 76.43% <76.43%> (ø)
... and 8 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@erha19 erha19 merged commit 0a645ff into main Sep 20, 2022
@erha19 erha19 deleted the fix/reveal-in-explorer-uri-type branch September 20, 2022 13:40
bytemain pushed a commit that referenced this pull request Sep 27, 2022
@erha19 erha19 mentioned this pull request Oct 12, 2022
55 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] 2.9.11 SCM 管理页面右键文件 > 在侧边栏打开 失效
3 participants