Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only handle scheme file on collaborative mode #1709

Merged
merged 4 commits into from
Sep 23, 2022

Conversation

situ2001
Copy link
Member

@situ2001 situ2001 commented Sep 22, 2022

Types

  • 🐛 Bug Fixes

Background or solution

handle了scheme不为file的TextModel,引起报错

image

Changelog

  • only handle scheme file on collaborative mode

@codecov
Copy link

codecov bot commented Sep 22, 2022

Codecov Report

Base: 57.68% // Head: 57.68% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (c135c8f) compared to base (ecb4569).
Patch coverage: 88.23% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1709   +/-   ##
=======================================
  Coverage   57.68%   57.68%           
=======================================
  Files        1269     1269           
  Lines       78979    78995   +16     
  Branches    16528    16532    +4     
=======================================
+ Hits        45559    45569   +10     
- Misses      30405    30410    +5     
- Partials     3015     3016    +1     
Flag Coverage Δ
jsdom 52.51% <17.64%> (-0.02%) ⬇️
node 15.80% <76.47%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...collaboration/src/browser/collaboration.service.ts 73.75% <50.00%> (-0.61%) ⬇️
...kages/collaboration/src/node/y-websocket-server.ts 80.00% <100.00%> (+3.80%) ⬆️
packages/monaco/src/browser/schema-registry.ts 68.88% <0.00%> (-2.23%) ⬇️
...erences/src/browser/preference-settings.service.ts 75.00% <0.00%> (-0.63%) ⬇️
...kages/theme/src/browser/workbench.theme.service.ts 70.76% <0.00%> (-0.59%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@erha19 erha19 merged commit fb474f8 into opensumi:main Sep 23, 2022
@erha19 erha19 mentioned this pull request Oct 12, 2022
55 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants