Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change statusbar view when tooltip updated #1712

Merged
merged 1 commit into from
Sep 23, 2022
Merged

Conversation

hacke2
Copy link
Member

@hacke2 hacke2 commented Sep 22, 2022

Types

  • 🐛 Bug Fixes

Background or solution

extension demo:

const statusBar = vscode.window.createStatusBarItem();

  statusBar.text = 'eslint';
  statusBar.tooltip = 'stopping';
  statusBar.show();

  setTimeout(() => {
    statusBar.tooltip = 'running';
  }, 3000);

Changelog

change statusbar view when tooltip updated

@hacke2
Copy link
Member Author

hacke2 commented Sep 22, 2022

resolve #1713

@codecov
Copy link

codecov bot commented Sep 22, 2022

Codecov Report

Base: 57.68% // Head: 57.67% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (475e9df) compared to base (ecb4569).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1712      +/-   ##
==========================================
- Coverage   57.68%   57.67%   -0.01%     
==========================================
  Files        1269     1269              
  Lines       78979    78979              
  Branches    16528    16528              
==========================================
- Hits        45559    45555       -4     
- Misses      30405    30408       +3     
- Partials     3015     3016       +1     
Flag Coverage Δ
jsdom 52.51% <ø> (-0.01%) ⬇️
node 15.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/monaco/src/browser/schema-registry.ts 68.88% <0.00%> (-2.23%) ⬇️
...erences/src/browser/preference-settings.service.ts 75.00% <0.00%> (-0.63%) ⬇️
...kages/theme/src/browser/workbench.theme.service.ts 70.76% <0.00%> (-0.59%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@erha19 erha19 merged commit 802bceb into main Sep 23, 2022
@erha19 erha19 deleted the fix/status-bar-tootip branch September 23, 2022 09:38
@Ricbet Ricbet linked an issue Sep 26, 2022 that may be closed by this pull request
@erha19 erha19 mentioned this pull request Oct 12, 2022
55 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] ESlint 运行中,但是显示还是停止
2 participants