Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: file tree input validateMessage not hide #1715

Merged
merged 1 commit into from
Sep 26, 2022

Conversation

Ricbet
Copy link
Member

@Ricbet Ricbet commented Sep 23, 2022

Types

  • 🐛 Bug Fixes

Background or solution

Changelog

修复文件树在提示错误信息时失焦后不消失的问题

@Ricbet Ricbet linked an issue Sep 23, 2022 that may be closed by this pull request
@Ricbet Ricbet self-assigned this Sep 23, 2022
@codecov
Copy link

codecov bot commented Sep 23, 2022

Codecov Report

Base: 57.68% // Head: 57.67% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (ba16ffc) compared to base (ecb4569).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1715      +/-   ##
==========================================
- Coverage   57.68%   57.67%   -0.01%     
==========================================
  Files        1269     1269              
  Lines       78979    78979              
  Branches    16528    16528              
==========================================
- Hits        45559    45555       -4     
- Misses      30405    30408       +3     
- Partials     3015     3016       +1     
Flag Coverage Δ
jsdom 52.51% <0.00%> (-0.01%) ⬇️
node 15.79% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...xt/src/browser/services/file-tree-model.service.ts 51.91% <0.00%> (ø)
packages/monaco/src/browser/schema-registry.ts 68.88% <0.00%> (-2.23%) ⬇️
...erences/src/browser/preference-settings.service.ts 75.00% <0.00%> (-0.63%) ⬇️
...kages/theme/src/browser/workbench.theme.service.ts 70.76% <0.00%> (-0.59%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@hacke2 hacke2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@erha19 erha19 merged commit 880e0d8 into main Sep 26, 2022
@erha19 erha19 deleted the fix/file-tree-valiadatemessage-input-blue branch September 26, 2022 06:48
@erha19 erha19 mentioned this pull request Oct 12, 2022
55 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] 新建相同名称的文件,其错误提示信息不会消失
3 participants