Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: select option style in light mode #1727

Merged
merged 1 commit into from
Sep 26, 2022
Merged

Conversation

hacke2
Copy link
Member

@hacke2 hacke2 commented Sep 26, 2022

Types

  • 💄 Code Style Changes

Background or solution

before:

image

after:
image

Changelog

select option style in light mode

@codecov
Copy link

codecov bot commented Sep 26, 2022

Codecov Report

Base: 57.68% // Head: 57.69% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (d039032) compared to base (a5e308c).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1727   +/-   ##
=======================================
  Coverage   57.68%   57.69%           
=======================================
  Files        1274     1274           
  Lines       79357    79357           
  Branches    16618    16618           
=======================================
+ Hits        45780    45784    +4     
+ Misses      30550    30547    -3     
+ Partials     3027     3026    -1     
Flag Coverage Δ
jsdom 52.54% <ø> (+<0.01%) ⬆️
node 15.78% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...kages/theme/src/browser/workbench.theme.service.ts 71.34% <0.00%> (+0.58%) ⬆️
...erences/src/browser/preference-settings.service.ts 75.62% <0.00%> (+0.62%) ⬆️
packages/monaco/src/browser/schema-registry.ts 71.11% <0.00%> (+2.22%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@erha19 erha19 merged commit c80ae4d into main Sep 26, 2022
@erha19 erha19 deleted the fix/select_option_color branch September 26, 2022 12:32
@erha19 erha19 mentioned this pull request Oct 12, 2022
55 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants