Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update high contrast theme #1728

Merged
merged 3 commits into from
Oct 9, 2022
Merged

Conversation

AhkunTa
Copy link
Member

@AhkunTa AhkunTa commented Sep 26, 2022

Types

  • 🎉 New Features
  • 💄 Style Changes

Background or solution

close #1410

  • 增加高对比度白色主题
  • 修改内部部分颜色注册值

截屏2022-09-30 14 16 03

Changelog

  • update high contrast light theme

@codecov
Copy link

codecov bot commented Sep 30, 2022

Codecov Report

Base: 52.54% // Head: 57.73% // Increases project coverage by +5.19% 🎉

Coverage data is based on head (1e817d1) compared to base (c80ae4d).
Patch coverage: 81.21% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1728      +/-   ##
==========================================
+ Coverage   52.54%   57.73%   +5.19%     
==========================================
  Files        1274     1278       +4     
  Lines       79357    79476     +119     
  Branches    16618    16636      +18     
==========================================
+ Hits        41697    45888    +4191     
+ Misses      34214    30562    -3652     
+ Partials     3446     3026     -420     
Flag Coverage Δ
jsdom 52.59% <81.21%> (+0.05%) ⬆️
node 15.86% <68.48%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../src/browser/vscode/api/main.thread.api.webview.ts 29.02% <0.00%> (ø)
.../extension/src/browser/vscode/contributes/color.ts 100.00% <ø> (ø)
packages/extension/src/common/vscode/ext-types.ts 50.68% <ø> (+0.14%) ⬆️
packages/extension/src/common/vscode/extension.ts 55.17% <ø> (ø)
packages/extension/src/common/vscode/webview.ts 100.00% <ø> (ø)
packages/i18n/src/common/en-US.lang.ts 100.00% <ø> (ø)
packages/i18n/src/common/zh-CN.lang.ts 100.00% <ø> (ø)
...ages/markers/src/browser/markers-seriverty-icon.ts 0.00% <0.00%> (ø)
...ckages/terminal-next/src/browser/terminal.color.ts 100.00% <ø> (ø)
packages/theme/src/browser/icon.service.ts 81.48% <ø> (ø)
... and 184 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@AhkunTa AhkunTa changed the title [WIP] feat: update high contrast theme feat: update high contrast theme Sep 30, 2022
@erha19 erha19 merged commit 568b04a into main Oct 9, 2022
@erha19 erha19 deleted the feat/update-hc-contrast-light-theme branch October 9, 2022 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] HighContrastLight API
2 participants