Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: custom electron headerbar title compoment #1730

Merged
merged 2 commits into from
Sep 27, 2022

Conversation

yantze
Copy link
Member

@yantze yantze commented Sep 26, 2022

Types

  • 🎉 New Features

Background or solution

image

- 默认在标题栏不加应用名 - 支持自定义标题栏组件,比如自己添加 commander 组件到 headerbar

红绿灯位置已经在 #1584 修复

Changelog

支持自定义 electron 的 header 组件

@yantze yantze force-pushed the feat/custom-electron-titlebar branch from 63bbb61 to 91ac20e Compare September 26, 2022 14:07
@codecov
Copy link

codecov bot commented Sep 26, 2022

Codecov Report

Base: 52.54% // Head: 57.69% // Increases project coverage by +5.15% 🎉

Coverage data is based on head (91ac20e) compared to base (c80ae4d).
Patch coverage: 0.00% of modified lines in pull request are covered.

❗ Current head 91ac20e differs from pull request most recent head 783ddca. Consider uploading reports for the commit 783ddca to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1730      +/-   ##
==========================================
+ Coverage   52.54%   57.69%   +5.15%     
==========================================
  Files        1274     1274              
  Lines       79357    79357              
  Branches    16618    16618              
==========================================
+ Hits        41697    45784    +4087     
+ Misses      34214    30547    -3667     
+ Partials     3446     3026     -420     
Flag Coverage Δ
jsdom 52.54% <0.00%> (ø)
node 15.78% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...tension/src/hosted/api/vscode/ext.host.api.impl.ts 91.95% <0.00%> (ø)
packages/utils/src/buffer.ts 30.81% <0.00%> (+1.74%) ⬆️
packages/core-common/src/types/editor.ts 15.09% <0.00%> (+1.88%) ⬆️
...ages/file-service/src/node/file-service-watcher.ts 76.87% <0.00%> (+2.89%) ⬆️
packages/core-common/src/log.ts 92.68% <0.00%> (+3.65%) ⬆️
...ckages/webview/src/webview-host/webview-manager.ts 4.26% <0.00%> (+4.26%) ⬆️
packages/utils/src/cancellation.ts 93.65% <0.00%> (+4.76%) ⬆️
packages/connection/src/common/ws-channel.ts 43.58% <0.00%> (+5.12%) ⬆️
packages/utils/src/strings.ts 34.19% <0.00%> (+5.18%) ⬆️
packages/file-service/src/common/files.ts 86.84% <0.00%> (+5.26%) ⬆️
... and 89 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@erha19 erha19 merged commit cc69ee8 into main Sep 27, 2022
@erha19 erha19 deleted the feat/custom-electron-titlebar branch September 27, 2022 02:23
@erha19 erha19 mentioned this pull request Oct 12, 2022
55 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants