Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support TreeView Drag API #1764

Merged
merged 4 commits into from
Oct 13, 2022
Merged

Conversation

erha19
Copy link
Member

@erha19 erha19 commented Oct 10, 2022

Types

  • 🎉 New Features

Background or solution

close #1402.

测试案例:https://github.com/microsoft/vscode-extension-samples/tree/drop-file-transfer

参考:microsoft/vscode#150321

Changelog

  • support TreeView Drag API

@erha19 erha19 force-pushed the feat/support-extension-tree-view-drag-api branch from 43960fc to 5007aba Compare October 10, 2022 14:10
@erha19
Copy link
Member Author

erha19 commented Oct 10, 2022

预览效果:

Kapture.2022-10-10.at.22.33.45.mp4

测试插件:https://github.com/microsoft/vscode-extension-samples/tree/drop-file-transfer/tree-view-sample

@erha19 erha19 force-pushed the feat/support-extension-tree-view-drag-api branch from 5e2defb to f717b99 Compare October 12, 2022 02:12
@codecov
Copy link

codecov bot commented Oct 12, 2022

Codecov Report

Base: 57.74% // Head: 57.59% // Decreases project coverage by -0.15% ⚠️

Coverage data is based on head (f717b99) compared to base (9614240).
Patch coverage: 32.93% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1764      +/-   ##
==========================================
- Coverage   57.74%   57.59%   -0.16%     
==========================================
  Files        1280     1283       +3     
  Lines       79571    80041     +470     
  Branches    16659    16776     +117     
==========================================
+ Hits        45952    46099     +147     
- Misses      30590    30873     +283     
- Partials     3029     3069      +40     
Flag Coverage Δ
jsdom 52.46% <32.93%> (-0.13%) ⬇️
node 15.80% <0.40%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ser/vscode/api/tree-view/tree-view.node.defined.ts 12.26% <0.00%> (ø)
.../src/hosted/api/vscode/ext.host.window.api.impl.ts 14.61% <0.00%> (ø)
...er/vscode/api/tree-view/tree-view.model.service.ts 21.29% <14.21%> (-4.93%) ⬇️
...kages/extension/src/common/vscode/data-transfer.ts 17.50% <17.50%> (ø)
packages/extension/src/common/vscode/ext-types.ts 50.17% <25.00%> (-0.52%) ⬇️
...extension/src/common/vscode/data-transfer-cache.ts 34.78% <34.78%> (ø)
...next/src/browser/services/file-tree-dnd.service.ts 69.33% <40.00%> (+0.14%) ⬆️
packages/extension/src/common/vscode/treeview.ts 48.00% <42.85%> (-27.00%) ⬇️
packages/extension/src/common/vscode/converter.ts 39.11% <44.82%> (+0.19%) ⬆️
...ion/src/browser/vscode/api/main.thread.treeview.ts 49.64% <58.13%> (+0.87%) ⬆️
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@erha19 erha19 mentioned this pull request Oct 12, 2022
55 tasks
Copy link
Member

@Ricbet Ricbet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@erha19 erha19 merged commit 4906df1 into main Oct 13, 2022
@erha19 erha19 deleted the feat/support-extension-tree-view-drag-api branch October 13, 2022 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Tree Drag API
2 participants