Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove useless component declaration #1782

Merged
merged 1 commit into from
Oct 13, 2022

Conversation

erha19
Copy link
Member

@erha19 erha19 commented Oct 13, 2022

Types

  • 🧹 Chores

Background or solution

close #281.

Changelog

@bytemain
Copy link
Member

@hacke2 是不是这个改动有坑在

@bytemain bytemain requested a review from hacke2 October 13, 2022 02:52
@codecov
Copy link

codecov bot commented Oct 13, 2022

Codecov Report

Base: 57.75% // Head: 57.75% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (581df55) compared to base (c37d137).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1782      +/-   ##
==========================================
- Coverage   57.75%   57.75%   -0.01%     
==========================================
  Files        1280     1280              
  Lines       79571    79567       -4     
  Branches    16659    16659              
==========================================
- Hits        45957    45950       -7     
- Misses      30586    30588       +2     
- Partials     3028     3029       +1     
Flag Coverage Δ
jsdom 52.58% <ø> (-0.01%) ⬇️
node 15.89% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/core-browser/src/browser-module.ts 100.00% <ø> (ø)
packages/editor/src/browser/index.ts 73.61% <ø> (-0.72%) ⬇️
packages/status-bar/src/browser/index.ts 100.00% <ø> (ø)
packages/utils/src/buffer.ts 33.13% <0.00%> (-1.75%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@hacke2 hacke2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@erha19 erha19 merged commit 2b6547d into main Oct 13, 2022
@erha19 erha19 deleted the chore/remove-useless-component-declaration branch October 13, 2022 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] 移除 BrowserModule 冗余的 component 结构
3 participants