Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: implement go to defination by cmd click #1786

Merged
merged 21 commits into from
Oct 31, 2022

Conversation

Ricbet
Copy link
Member

@Ricbet Ricbet commented Oct 13, 2022

Types

  • ⏱ Tests

Background or solution

Changelog

新增 "通过鼠标 Go To Defination" 的 e2e 测试

@Ricbet Ricbet requested review from hacke2 and erha19 October 13, 2022 05:44
@Ricbet Ricbet self-assigned this Oct 13, 2022
@Ricbet Ricbet changed the title Test/implement go to defination by cmd click test: implement go to defination by cmd click Oct 13, 2022
@erha19
Copy link
Member

erha19 commented Oct 13, 2022

@Ricbet 看一下,这个修改会导致其他测试挂掉
image

Aaaaash
Aaaaash previously approved these changes Oct 18, 2022
Copy link
Member

@erha19 erha19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个目前是有报错的

@Ricbet Ricbet force-pushed the test/implement-go-to-defination-by-cmd-click branch 5 times, most recently from 397e0a3 to 0fa34e9 Compare October 25, 2022 07:58
@Ricbet Ricbet force-pushed the test/implement-go-to-defination-by-cmd-click branch 3 times, most recently from 8041295 to 84de681 Compare October 27, 2022 07:04
@Ricbet Ricbet changed the title test: implement go to defination by cmd click WIP: test: implement go to defination by cmd click Oct 27, 2022
@Ricbet Ricbet changed the title WIP: test: implement go to defination by cmd click test: implement go to defination by cmd click Oct 28, 2022
@Ricbet
Copy link
Member Author

Ricbet commented Oct 28, 2022

这个目前是有报错的

CI 过了

@Ricbet Ricbet force-pushed the test/implement-go-to-defination-by-cmd-click branch from c294b2b to c1c2405 Compare October 28, 2022 08:44
@erha19 erha19 merged commit 8e9c90f into main Oct 31, 2022
@erha19 erha19 deleted the test/implement-go-to-defination-by-cmd-click branch October 31, 2022 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants