Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support smart commit with 1.69.0 git extension #1805

Merged
merged 2 commits into from
Oct 21, 2022

Conversation

erha19
Copy link
Member

@erha19 erha19 commented Oct 19, 2022

Types

  • 🐛 Bug Fixes

Background or solution

Kapture.2022-10-19.at.12.02.00.mp4

Changelog

support smart commit with 1.69.0 git extension

@codecov
Copy link

codecov bot commented Oct 19, 2022

Codecov Report

Base: 57.61% // Head: 57.62% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (eb05c84) compared to base (987dc95).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1805   +/-   ##
=======================================
  Coverage   57.61%   57.62%           
=======================================
  Files        1285     1285           
  Lines       80171    80175    +4     
  Branches    16793    16796    +3     
=======================================
+ Hits        46191    46198    +7     
+ Misses      30909    30907    -2     
+ Partials     3071     3070    -1     
Flag Coverage Δ
jsdom 52.36% <0.00%> (+<0.01%) ⬆️
node 15.90% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...xtension/src/hosted/api/vscode/ext.host.command.ts 67.60% <0.00%> (ø)
...kages/terminal-next/src/browser/terminal.client.ts 72.77% <0.00%> (-0.85%) ⬇️
packages/utils/src/buffer.ts 34.88% <0.00%> (+4.06%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bytemain
Copy link
Member

这个按钮上的文字怎么木有了

@erha19
Copy link
Member Author

erha19 commented Oct 19, 2022

按钮上的文字是依赖插件处理的返回值的,有差别可能就是要再往上升插件了

@erha19 erha19 merged commit 385cd4b into main Oct 21, 2022
@erha19 erha19 deleted the fix/support-smart-commit-with-1.69.0 branch October 21, 2022 02:18
@erha19 erha19 added this to Done in Make SCM Great Again Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants